Skip to content

Commit e72c145

Browse files
Alex Eaglealexeagle
Alex Eagle
authored andcommitted
fix(builtin): give a longer timeout for _create_build_files
A user reports that their build file generation takes longer than 600 seconds. It's probably a bug that we are so slow, but let's address that separately (maybe in our work for npm v7) Also note we could have made this timeout user-configurable, but I think the extra API surface isn't worth the benefit. Fixes #2231
1 parent 8bbc27b commit e72c145

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/npm_install/npm_install.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def _create_build_files(repository_ctx, rule_type, node, lock_file):
131131
str(repository_ctx.attr.strict_visibility),
132132
",".join(repository_ctx.attr.included_files),
133133
native.bazel_version,
134-
])
134+
], timeout = 1200) # double the default timeout in case of many packages, see #2231
135135
if result.return_code:
136136
fail("generate_build_file.ts failed: \nSTDOUT:\n%s\nSTDERR:\n%s" % (result.stdout, result.stderr))
137137

0 commit comments

Comments
 (0)