railsy result

Author: NullVoxPopuli

lib/jsonapi/rails/deserializable_resource.rb

@@ -18,7 +18,7 @@ module Rails
     #  - allow custom deserializable_classes?
     #    - then this gem would just be a very light weight wrapper around
     #      jsonapi/deserializable
-    class DeserializableResource < JSONAPI::Deserializable::Resource
+    class DeserializableResource
       require_relative 'deserializable_resource/builder'
 
       class << self
@@ -66,7 +66,7 @@ def to_hash
         type = _hash['data']['type']
         klass = self.class.deserializable_class(type, _klass)
 
-        self.class[klass].call(_hash)
+        self.class[klass].call(_hash).with_indifferent_access
       end
     end
   end

lib/jsonapi/rails/deserializable_resource/builder.rb

@@ -8,7 +8,7 @@ module Builder
 
         def for_class(klass)
           builder = self
-          Class.new(JSONAPI::Rails::DeserializableResource) do
+          Class.new(JSONAPI::Deserializable::Resource) do
             # All Attributes
             builder.define_attributes(self, klass)
 
@@ -40,7 +40,7 @@ def define_associations(deserializable, klass)
               else
                 has_one name do |rel|
                   field "#{name}_id" => rel['data'] && rel['data']['id']
-                  field "#{name}_type" => rel['data'] && rel['data']['type']
+                  field "#{name}_type" => rel['data'] && rel['data']['type'].classify
                 end
               end
             end

spec/integration/active_record/deserializable_resource_spec.rb

@@ -5,11 +5,20 @@
 
   around(:each) do |example|
     with_temporary_database(lambda do
-                              create_table :posts
+                              create_table :posts do |t|
+                                t.string :name
+                                t.string :body
+                                t.references :author, polymorphic: true
+                              end
+
+                              create_table :users do |t|
+                                t.string :name
+                              end
                             end) do
       # Clear cache just in case a test runs before this one
       klass.instance_variable_set('@deserializable_cache', {})
-      class Post < ActiveRecord::Base; end
+      class Post < ActiveRecord::Base; belongs_to :author, polymorphic: true; end
+      class User < ActiveRecord::Base; has_many :posts; end
       example.run
     end
   end
@@ -21,24 +30,62 @@ class Post < ActiveRecord::Base; end
   end
 
   context 'deserializing a jsonapi document' do
-    before(:all) do
-      @payload = {
-        'data' => {
-          'id' => '1',
-          'type' => 'posts',
-          'attributes' => {
-            'name' => 'Name',
-            'body' => 'content'
+    context 'with attributes' do
+      before(:all) do
+        @payload = {
+          'data' => {
+            'id' => '1',
+            'type' => 'posts',
+            'attributes' => {
+              'name' => 'Name',
+              'body' => 'content'
+            },
+            'relationships' => {}
           }
         }
-      }
+      end
+
+      it 'pulls out the attributes' do
+        result = JSONAPI::Rails.to_active_record_hash(@payload, options: {}, klass: Post)
+        expected = { 'name' => 'Name', 'body' => 'content' }
+
+        expect(result).to eq expected
+      end
     end
 
-    it 'pulls out the attributes' do
-      result = JSONAPI::Rails.to_active_record_hash(@payload, options: {}, klass: Post)
-      expected = { 'name' => 'Name', 'body' => 'content' }
+    context 'with polymorphic relationships' do
+      before(:all) do
+        @payload = {
+          'data' => {
+            'id' => '1',
+            'type' => 'posts',
+            'attributes' => {
+              'name' => 'Name',
+              'body' => 'content'
+            },
+            'relationships' => {
+              'author' => {
+                'data' => {
+                  'id' => 1,
+                  'type' => 'users'
+                }
+              }
+            }
+          }
+        }
+      end
+
+      it 'pulls out the attributes' do
+        result = JSONAPI::Rails.to_active_record_hash(@payload, options: {}, klass: Post)
+        expected = {
+          'name' => 'Name',
+          'body' => 'content',
+          'author_id' => 1,
+          'author_type' => 'User'
+        }
 
-      expect(result).to eq expected
+        expect(result).to eq expected
+      end
     end
   end
 end

spec/unit/jsonapi/rails/deserializable_resource/builder_spec.rb

@@ -3,14 +3,22 @@
   let(:klass) { JSONAPI::Rails::DeserializableResource::Builder }
 
   describe '.for_class' do
-    it 'can be instantiated' do
+    it 'returns a DeserializableResource' do
       with_temporary_database(lambda do
                                 create_table :posts
                               end) do
         class Post < ActiveRecord::Base; end
         deserializer = klass.for_class(Post)
 
-        expect(deserializer.new({})).to be_a_kind_of JSONAPI::Rails::DeserializableResource
+        dummy_payload = {
+          'data' => {
+            'id' => '1',
+            'type' => 'posts',
+            'attributes' => {}
+          }
+        }
+
+        expect(deserializer.new(dummy_payload)).to be_a_kind_of JSONAPI::Deserializable::Resource
       end
     end
 

spec/unit/jsonapi/rails/deserializable_resource_spec.rb

@@ -54,16 +54,6 @@ class Post < ActiveRecord::Base; end
     end
   end
 
-  describe '.new' do
-    it 'caches generated classes' do
-
-    end
-  end
-
-  describe '#to_h' do
-
-  end
-
   context 'options' do
     context 'polymorphic' do