Skip to content

Commit 68c990a

Browse files
committed
[WIP] News87: PR Review Club summaries
1 parent 85d16b5 commit 68c990a

File tree

1 file changed

+52
-0
lines changed

1 file changed

+52
-0
lines changed
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
---
2+
title: 'Bitcoin Optech Newsletter #87'
3+
permalink: /en/newsletters/2020/03/04/
4+
name: 2020-03-04-newsletter
5+
slug: 2020-03-04-newsletter
6+
type: newsletter
7+
layout: newsletter
8+
lang: en
9+
---
10+
11+
## Action items
12+
13+
## News
14+
15+
## Highlights from the Bitcoin Core PR Review Club
16+
17+
The [Bitcoin Core PR Review Club][] is a weekly IRC meeting for newer
18+
contributors to the Bitcoin Core project to learn about how to take part in the
19+
review process. An experienced Bitcoin Core contributor provides background
20+
information about a selected Pull Request and then leads a discussion about the
21+
PR on IRC.
22+
23+
The Review Club is an excellent way to learn about the Bitcoin protocol, the
24+
Bitcoin Core reference implementation, and the process of making changes to
25+
Bitcoin. Notes, questions and meeting logs are posted on the website for each
26+
meeting for those who are unable to attend in real time, and as a permanent
27+
resource for those wishing to learn about the Bitcoin Core development process.
28+
29+
In this section, we summarise some recent Review Club meetings.
30+
31+
- **[O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation / Abstract out script execution out of VerifyWitnessProgram()][review club 16902]:**
32+
These Pull Requests ([Bitcoin Core #16902][] and [Bitcoin Core #18002][]) are
33+
both small refactors that have been pulled out of the [Schnorr/Taproot
34+
implementation PR][Bitcoin Core #17977]. The author explains in PR 18002:
35+
"[this] simplifies the changes for Taproot significantly, and if it's going to
36+
be necessitated by inclusion of that code, I may as well give it some
37+
additional attention by PRing it independently."
38+
39+
Both PRs make changes to the Bitcoin Core's script interpreter code -- a
40+
section of the codebase which is at the heart of Bitcoin Core's consensus
41+
rules implementation, and is therefore very seldom changed by developers.
42+
Discussion in the Review Club was centered on Bitcoin Core's use of asserts and
43+
logging; performance and benchmarking; and how we can test and review changes
44+
to consensus-critical code.
45+
46+
[Bitcoin Core PR Review Club]:https://bitcoin-core-review-club.github.io/
47+
48+
## Notable code and documentation changes
49+
50+
{% include references.md %}
51+
{% include linkers/issues.md issues="16902,17977,18002" %}
52+
[review club 16902]: https://bitcoincore.reviews/16902.html

0 commit comments

Comments
 (0)