|
| 1 | +--- |
| 2 | +title: 'Bitcoin Optech Newsletter #87' |
| 3 | +permalink: /en/newsletters/2020/03/04/ |
| 4 | +name: 2020-03-04-newsletter |
| 5 | +slug: 2020-03-04-newsletter |
| 6 | +type: newsletter |
| 7 | +layout: newsletter |
| 8 | +lang: en |
| 9 | +--- |
| 10 | + |
| 11 | +## Action items |
| 12 | + |
| 13 | +## News |
| 14 | + |
| 15 | +## Highlights from the Bitcoin Core PR Review Club |
| 16 | + |
| 17 | +The [Bitcoin Core PR Review Club][] is a weekly IRC meeting for newer |
| 18 | +contributors to the Bitcoin Core project to learn about the review process. An |
| 19 | +experienced Bitcoin Core contributor provides background information about a |
| 20 | +selected PR and then leads a discussion on IRC. |
| 21 | + |
| 22 | +The Review Club is an excellent way to learn about the Bitcoin protocol, the |
| 23 | +Bitcoin Core reference implementation, and the process of making changes to |
| 24 | +Bitcoin. Notes, questions and meeting logs are posted on the website for those |
| 25 | +who are unable to attend in real time, and as a permanent resource for those |
| 26 | +wishing to learn about the Bitcoin Core development process. |
| 27 | + |
| 28 | +In this section, we summarise some recent Review Club meetings. |
| 29 | + |
| 30 | +- **[O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation / Abstract out script execution out of VerifyWitnessProgram()][review club 16902]:** |
| 31 | + These PRs ([Bitcoin Core #16902][] and [Bitcoin Core #18002][]) are |
| 32 | + both small refactors that have been pulled out of the [Schnorr/Taproot |
| 33 | + implementation PR][Bitcoin Core #17977]. The author explains in PR 18002: |
| 34 | + "[this] simplifies the changes for Taproot significantly [...] I may as well |
| 35 | + give it some additional attention by PRing it independently." |
| 36 | + |
| 37 | + Both PRs make changes to the Bitcoin Core's script interpreter code -- a |
| 38 | + section of the codebase which is very seldom changed by developers. Discussion |
| 39 | + in the meeting covered the use of asserts and logging in Bitcoin Core, performance |
| 40 | + and benchmarking, and how to test and review changes to consensus-critical |
| 41 | + code. |
| 42 | + |
| 43 | +[Bitcoin Core PR Review Club]: https://bitcoincore.reviews |
| 44 | + |
| 45 | +## Notable code and documentation changes |
| 46 | + |
| 47 | +{% include references.md %} |
| 48 | +{% include linkers/issues.md issues="16902,17977,18002" %} |
| 49 | +[review club 16902]: https://bitcoincore.reviews/16902 |
0 commit comments