Merge branch 'main' into milestone-labels

* main: (90 commits)
  Refactor rename user and rename organization (go-gitea#24052)
  Use `CommentList` instead of `[]*Comment` (go-gitea#24828)
  Fix topics deleted via API not being deleted in org page (go-gitea#24825)
  Return `404` in the API if the requested webhooks were not found (go-gitea#24823)
  Decouple the different contexts from each other (go-gitea#24786)
  [skip ci] Updated translations via Crowdin
  Add RTL rendering support to Markdown (go-gitea#24816)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#24815)
  Fix duplicate tooltip hiding (go-gitea#24814)
  Mute repo names in dashboard repo list (go-gitea#24811)
  Rework label colors (go-gitea#24790)
  Fix max width and margin of comment box on conversation page (go-gitea#24809)
  Allow all URL schemes in Markdown links by default (go-gitea#24805)
  Some refactors for issues stats (go-gitea#24793)
  Implement actions artifacts (go-gitea#22738)
  Fix Actions being enabled accidentally (go-gitea#24802)
  Change `add_on` in `keys_ssh.tmpl` (go-gitea#24803)
  replace `drone exec` to `act_runner exec` in test README.md (go-gitea#24791)
  Fix OAuth loading state (go-gitea#24788)
  ...

Author: silverwind

.eslintrc.yaml

@@ -9,13 +9,17 @@ parserOptions:
   ecmaVersion: latest
 
 plugins:
-  - eslint-plugin-unicorn
+  - "@eslint-community/eslint-plugin-eslint-comments"
+  - eslint-plugin-array-func
+  - eslint-plugin-custom-elements
   - eslint-plugin-import
   - eslint-plugin-jquery
   - eslint-plugin-no-jquery
-  - eslint-plugin-sonarjs
-  - eslint-plugin-custom-elements
+  - eslint-plugin-no-use-extend-native
   - eslint-plugin-regexp
+  - eslint-plugin-sonarjs
+  - eslint-plugin-unicorn
+  - eslint-plugin-wc
 
 env:
   es2022: true
@@ -43,11 +47,26 @@ overrides:
       import/no-unused-modules: [0]
 
 rules:
+  "@eslint-community/eslint-comments/disable-enable-pair": [2]
+  "@eslint-community/eslint-comments/no-aggregating-enable": [2]
+  "@eslint-community/eslint-comments/no-duplicate-disable": [2]
+  "@eslint-community/eslint-comments/no-restricted-disable": [0]
+  "@eslint-community/eslint-comments/no-unlimited-disable": [2]
+  "@eslint-community/eslint-comments/no-unused-disable": [2]
+  "@eslint-community/eslint-comments/no-unused-enable": [2]
+  "@eslint-community/eslint-comments/no-use": [0]
+  "@eslint-community/eslint-comments/require-description": [0]
   accessor-pairs: [2]
   array-bracket-newline: [0]
   array-bracket-spacing: [2, never]
   array-callback-return: [2, {checkForEach: true}]
   array-element-newline: [0]
+  array-func/avoid-reverse: [2]
+  array-func/from-map: [2]
+  array-func/no-unnecessary-this-arg: [2]
+  array-func/prefer-array-from: [2]
+  array-func/prefer-flat-map: [0] # handled by unicorn/prefer-array-flat-map
+  array-func/prefer-flat: [0] # handled by unicorn/prefer-array-flat
   arrow-body-style: [0]
   arrow-parens: [2, always]
   arrow-spacing: [2, {before: true, after: true}]
@@ -433,6 +452,7 @@ rules:
   no-unused-private-class-members: [2]
   no-unused-vars: [2, {args: all, argsIgnorePattern: ^_, varsIgnorePattern: ^_, caughtErrorsIgnorePattern: ^_, destructuredArrayIgnorePattern: ^_, ignoreRestSiblings: false}]
   no-use-before-define: [2, {functions: false, classes: true, variables: true, allowNamedExports: true}]
+  no-use-extend-native/no-use-extend-native: [2]
   no-useless-backreference: [2]
   no-useless-call: [2]
   no-useless-catch: [2]
@@ -717,6 +737,15 @@ rules:
   use-isnan: [2]
   valid-typeof: [2, {requireStringLiterals: true}]
   vars-on-top: [0]
+  wc/attach-shadow-constructor: [2]
+  wc/guard-super-call: [2]
+  wc/no-closed-shadow-root: [2]
+  wc/no-constructor-attributes: [2]
+  wc/no-constructor-params: [2]
+  wc/no-invalid-element-name: [0] # covered by custom-elements/valid-tag-name
+  wc/no-self-class: [2]
+  wc/no-typos: [2]
+  wc/require-listener-teardown: [2]
   wrap-iife: [2, inside]
   wrap-regex: [0]
   yield-star-spacing: [2, after]

.github/workflows/cron-licenses.yml

@@ -6,8 +6,8 @@ on:
 
 jobs:
   cron-licenses:
-    if: github.repository == "go-gitea/gitea"
     runs-on: ubuntu-latest
+    if: github.repository == 'go-gitea/gitea'
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3

.github/workflows/cron-lock.yml

@@ -15,6 +15,7 @@ concurrency:
 jobs:
   action:
     runs-on: ubuntu-latest
+    if: github.repository == 'go-gitea/gitea'
     steps:
       - uses: dessant/lock-threads@v4
         with:

.github/workflows/cron-translations.yml

@@ -7,6 +7,7 @@ on:
 jobs:
   crowdin-pull:
     runs-on: ubuntu-latest
+    if: github.repository == 'go-gitea/gitea'
     steps:
       - uses: actions/checkout@v3
       - name: download from crowdin
@@ -31,13 +32,15 @@ jobs:
           ssh_key: ${{ secrets.DEPLOY_KEY }}
   crowdin-push:
     runs-on: ubuntu-latest
+    if: github.repository == 'go-gitea/gitea'
     steps:
       - uses: actions/checkout@v3
       - name: push translations to crowdin
         uses: docker://jonasfranz/crowdin
         env:
           CROWDIN_KEY: ${{ secrets.CROWDIN_KEY }}
           PLUGIN_UPLOAD: true
+          PLUGIN_EXPORT_DIR: options/locale/
           PLUGIN_IGNORE_BRANCH: true
           PLUGIN_PROJECT_IDENTIFIER: gitea
           PLUGIN_FILES: |

.github/workflows/pull-compliance-docsignore.yml

@@ -0,0 +1,43 @@
+name: compliance
+
+on:
+  pull_request:
+    paths:
+      - "docs/**"
+      - "*.md"
+
+jobs:
+  compliance-docs:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  lint-backend:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  lint-go-windows:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  lint-go-gogit:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  checks-backend:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  frontend:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  backend:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"

.github/workflows/pull-compliance.yml

@@ -1,6 +1,10 @@
 name: compliance
 
-on: [pull_request]
+on:
+  pull_request:
+    paths-ignore:
+      - "docs/**"
+      - "*.md"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}

.github/workflows/pull-db-tests-docsignore.yml

@@ -0,0 +1,38 @@
+name: db-tests
+
+on:
+  pull_request:
+    paths:
+      - "docs/**"
+      - "*.md"
+
+jobs:
+  test-pgsql:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  test-sqlite:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  test-unit:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  test-mysql5:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  test-mysql8:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"
+
+  test-mssql:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"

.github/workflows/pull-db-tests.yml

@@ -1,6 +1,10 @@
 name: db-tests
 
-on: [pull_request]
+on:
+  pull_request:
+    paths-ignore:
+      - "docs/**"
+      - "*.md"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
@@ -37,7 +41,7 @@ jobs:
         with:
           go-version: ">=1.20.0"
       - name: Add hosts to /etc/hosts
-        run: echo "127.0.0.1 pgsql ldap minio" | sudo tee -a /etc/hosts
+        run: '[ -e "/.dockerenv" ] || [ -e "/run/.containerenv" ] || echo "127.0.0.1 pgsql ldap minio" | sudo tee -a /etc/hosts'
       - run: make deps-backend
       - run: make backend
         env:
@@ -102,13 +106,20 @@ jobs:
           --health-retries 10
         ports:
           - 6379:6379
+      minio:
+        image: bitnami/minio:2021.3.17
+        env:
+          MINIO_ACCESS_KEY: 123456
+          MINIO_SECRET_KEY: 12345678
+        ports:
+          - "9000:9000"
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v4
         with:
           go-version: ">=1.20.0"
       - name: Add hosts to /etc/hosts
-        run: echo "127.0.0.1 mysql elasticsearch smtpimap" | sudo tee -a /etc/hosts
+        run: '[ -e "/.dockerenv" ] || [ -e "/run/.containerenv" ] || echo "127.0.0.1 mysql elasticsearch smtpimap" | sudo tee -a /etc/hosts'
       - run: make deps-backend
       - run: make backend
         env:
@@ -155,7 +166,7 @@ jobs:
         with:
           go-version: ">=1.20.0"
       - name: Add hosts to /etc/hosts
-        run: echo "127.0.0.1 mysql elasticsearch smtpimap" | sudo tee -a /etc/hosts
+        run: '[ -e "/.dockerenv" ] || [ -e "/run/.containerenv" ] || echo "127.0.0.1 mysql elasticsearch smtpimap" | sudo tee -a /etc/hosts'
       - run: make deps-backend
       - run: make backend
         env:
@@ -184,7 +195,7 @@ jobs:
         with:
           go-version: ">=1.20.0"
       - name: Add hosts to /etc/hosts
-        run: echo "127.0.0.1 mysql8" | sudo tee -a /etc/hosts
+        run: '[ -e "/.dockerenv" ] || [ -e "/run/.containerenv" ] || echo "127.0.0.1 mysql8" | sudo tee -a /etc/hosts'
       - run: make deps-backend
       - run: make backend
         env:
@@ -212,7 +223,7 @@ jobs:
         with:
           go-version: ">=1.20.0"
       - name: Add hosts to /etc/hosts
-        run: echo "127.0.0.1 mssql" | sudo tee -a /etc/hosts
+        run: '[ -e "/.dockerenv" ] || [ -e "/run/.containerenv" ] || echo "127.0.0.1 mssql" | sudo tee -a /etc/hosts'
       - run: make deps-backend
       - run: make backend
         env:

.github/workflows/pull-docker-dryrun-docsignore.yml

@@ -0,0 +1,13 @@
+name: docker-dryrun
+
+on:
+  pull_request:
+    paths:
+      - "docs/**"
+      - "*.md"
+
+jobs:
+  docker-dryrun:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"

.github/workflows/pull-docker-dryrun.yml

@@ -1,6 +1,10 @@
 name: docker-dryrun
 
-on: [pull_request]
+on:
+  pull_request:
+    paths-ignore:
+      - "docs/**"
+      - "*.md"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}

.github/workflows/pull-e2e-tests-docsignore.yml

@@ -0,0 +1,13 @@
+name: e2e-tests
+
+on:
+  pull_request:
+    paths:
+      - "docs/**"
+      - "*.md"
+
+jobs:
+  test-e2e:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "No build required"

.github/workflows/pull-e2e-tests.yml

@@ -1,6 +1,10 @@
 name: e2e-tests
 
-on: [pull_request]
+on:
+  pull_request:
+    paths-ignore:
+      - "docs/**"
+      - "*.md"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}

.stylelintrc.yaml

@@ -5,7 +5,7 @@ ignoreFiles:
   - "**/*.go"
 
 overrides:
-  - files: ["**/chroma/*", "**/codemirror/*", "**/standalone/*", "**/console/*"]
+  - files: ["**/chroma/*", "**/codemirror/*", "**/standalone/*", "**/console.css"]
     rules:
       scale-unlimited/declaration-strict-value: null
   - files: ["**/chroma/*", "**/codemirror/*"]

Dockerfile

@@ -1,5 +1,5 @@
 #Build stage
-FROM docker.io/library/golang:1.20-alpine3.17 AS build-env
+FROM docker.io/library/golang:1.20-alpine3.18 AS build-env
 
 ARG GOPROXY
 ENV GOPROXY ${GOPROXY:-direct}
@@ -23,7 +23,7 @@ RUN if [ -n "${GITEA_VERSION}" ]; then git checkout "${GITEA_VERSION}"; fi \
 # Begin env-to-ini build
 RUN go build contrib/environment-to-ini/environment-to-ini.go
 
-FROM docker.io/library/alpine:3.17
+FROM docker.io/library/alpine:3.18
 LABEL maintainer="[email protected]"
 
 EXPOSE 22 3000

Dockerfile.rootless

@@ -1,5 +1,5 @@
 #Build stage
-FROM docker.io/library/golang:1.20-alpine3.17 AS build-env
+FROM docker.io/library/golang:1.20-alpine3.18 AS build-env
 
 ARG GOPROXY
 ENV GOPROXY ${GOPROXY:-direct}
@@ -23,7 +23,7 @@ RUN if [ -n "${GITEA_VERSION}" ]; then git checkout "${GITEA_VERSION}"; fi \
 # Begin env-to-ini build
 RUN go build contrib/environment-to-ini/environment-to-ini.go
 
-FROM docker.io/library/alpine:3.17
+FROM docker.io/library/alpine:3.18
 LABEL maintainer="[email protected]"
 
 EXPOSE 2222 3000

MAINTAINERS

@@ -50,3 +50,4 @@ Eddie Yang <[email protected]> (@yp05327)
 Dong Ge <[email protected]> (@sillyguodong)
 Xinyi Gong <[email protected]> (@HesterG)
 wxiaoguang <[email protected]> (@wxiaoguang)
+Gary Moon <[email protected]> (@garymoon)