Skip to content

Commit fcbbd0d

Browse files
[Github][CI] Make the new premerge system fail jobs on errors
This patch makes the new premerge system report failures when the build errors out. We were previously not doing this to not notify people on failures as we were testing out the infra. This works towards making the new premerge system canonical and the deprecation of the old system. A launch announcement on Discourse will accompany this commit. Pull Request: llvm#139359
1 parent 9bfe15c commit fcbbd0d

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

.github/workflows/premerge.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ jobs:
4242
# Mark the job as a success even if the step fails so that people do
4343
# not get notified while the new premerge pipeline is in an
4444
# experimental state.
45-
# TODO(boomanaiden154): Remove this once the pipeline is stable and we
46-
# are ready for people to start recieving notifications.
47-
continue-on-error: true
4845
run: |
4946
git config --global --add safe.directory '*'
5047
@@ -109,9 +106,6 @@ jobs:
109106
# Mark the job as a success even if the step fails so that people do
110107
# not get notified while the new premerge pipeline is in an
111108
# experimental state.
112-
# TODO(boomanaiden154): Remove this once the pipeline is stable and we
113-
# are ready for people to start recieving notifications.
114-
continue-on-error: true
115109
if: ${{ steps.vars.outputs.windows-projects != '' }}
116110
shell: cmd
117111
run: |

0 commit comments

Comments
 (0)