only release the string if it is not interned

withinboredom · withinboredom · commit d1ca6c2fe27c · 2025-03-29T09:33:47.000+01:00
diff --git a/Zend/zend_API.c b/Zend/zend_API.c
@@ -2905,7 +2905,9 @@ ZEND_API void zend_type_free_interned_trees(void) {
 			pefree(tree->compound.types, 1);
 		} else {
 			if (ZEND_TYPE_HAS_NAME(tree->simple_type)) {
-				zend_string_release_ex(ZEND_TYPE_NAME(tree->simple_type), 1);
+				if (!ZSTR_IS_INTERNED(ZEND_TYPE_NAME(tree->simple_type))) {
+					zend_string_release_ex(ZEND_TYPE_NAME(tree->simple_type), 1);
+				}
 			}
 		}
 		pefree(tree, 1);

Original file line number	Diff line number	Diff line change
`@@ -2905,7 +2905,9 @@ ZEND_API void zend_type_free_interned_trees(void) {`
`2905`	`2905`	`pefree(tree->compound.types, 1);`
`2906`	`2906`	`} else {`
`2907`	`2907`	`if (ZEND_TYPE_HAS_NAME(tree->simple_type)) {`
`2908`		`- zend_string_release_ex(ZEND_TYPE_NAME(tree->simple_type), 1);`
	`2908`	`+ if (!ZSTR_IS_INTERNED(ZEND_TYPE_NAME(tree->simple_type))) {`
	`2909`	`+ zend_string_release_ex(ZEND_TYPE_NAME(tree->simple_type), 1);`
	`2910`	`+ }`
`2909`	`2911`	`}`
`2910`	`2912`	`}`
`2911`	`2913`	`pefree(tree, 1);`