Skip to content

Commit 28d2220

Browse files
fix: remove quotation mark when date or datetime is used in queryParams (box/box-codegen#509) (#225)
1 parent 6c18ca3 commit 28d2220

File tree

5 files changed

+36
-18
lines changed

5 files changed

+36
-18
lines changed

.codegen.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ "engineHash": "3ed6b56", "specHash": "5e023b9", "version": "1.0.0" }
1+
{ "engineHash": "240a5b0", "specHash": "5e023b9", "version": "1.0.0" }

docs/events.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ See the endpoint docs at
2424

2525
```ts
2626
await client.events.getEvents({
27-
streamType: 'changes' as GetEventsQueryParamsStreamTypeField,
27+
streamType: 'admin_logs' as GetEventsQueryParamsStreamTypeField,
28+
limit: 1,
29+
createdAfter: createdAfterDate,
30+
createdBefore: createdBeforeDate,
2831
} satisfies GetEventsQueryParams);
2932
```
3033

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/managers/events.generated.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -230,16 +230,12 @@ export class EventsManager {
230230
['event_type']: queryParams.eventType
231231
? queryParams.eventType.map(toString).join(',')
232232
: undefined,
233-
['created_after']: sdToJson(
234-
queryParams.createdAfter
235-
? serializeDateTime(queryParams.createdAfter)
236-
: undefined
237-
) as string,
238-
['created_before']: sdToJson(
239-
queryParams.createdBefore
240-
? serializeDateTime(queryParams.createdBefore)
241-
: undefined
242-
) as string,
233+
['created_after']: queryParams.createdAfter
234+
? serializeDateTime(queryParams.createdAfter)
235+
: undefined,
236+
['created_before']: queryParams.createdBefore
237+
? serializeDateTime(queryParams.createdBefore)
238+
: undefined,
243239
});
244240
const headersMap: {
245241
readonly [key: string]: string;

src/test/events.generated.test.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ import { serializeRealtimeServers } from '../schemas/realtimeServers.generated.j
1010
import { deserializeRealtimeServers } from '../schemas/realtimeServers.generated.js';
1111
import { serializeRealtimeServer } from '../schemas/realtimeServer.generated.js';
1212
import { deserializeRealtimeServer } from '../schemas/realtimeServer.generated.js';
13+
import { serializeDateTime } from '../internal/utils.js';
14+
import { deserializeDateTime } from '../internal/utils.js';
1315
import { serializeEventSource } from '../schemas/eventSource.generated.js';
1416
import { deserializeEventSource } from '../schemas/eventSource.generated.js';
1517
import { serializeFile } from '../schemas/file.generated.js';
@@ -26,11 +28,13 @@ import { GetEventsQueryParamsStreamTypeField } from '../managers/events.generate
2628
import { GetEventsQueryParamsEventTypeField } from '../managers/events.generated.js';
2729
import { RealtimeServers } from '../schemas/realtimeServers.generated.js';
2830
import { RealtimeServer } from '../schemas/realtimeServer.generated.js';
31+
import { DateTime } from '../internal/utils.js';
2932
import { getDefaultClient } from './commons.generated.js';
3033
import { EventSource } from '../schemas/eventSource.generated.js';
3134
import { File } from '../schemas/file.generated.js';
3235
import { Folder } from '../schemas/folder.generated.js';
3336
import { User } from '../schemas/user.generated.js';
37+
import { dateTimeFromString } from '../internal/utils.js';
3438
import { toString } from '../internal/utils.js';
3539
import { sdToJson } from '../serialization/json.js';
3640
import { SerializedData } from '../serialization/json.js';
@@ -137,4 +141,19 @@ test('testGetEventsWithLongPolling', async function testGetEventsWithLongPolling
137141
throw new Error('Assertion failed');
138142
}
139143
});
144+
test('testGetEventsWithDateFilters', async function testGetEventsWithDateFilters(): Promise<any> {
145+
const createdAfterDate: DateTime = dateTimeFromString('2024-06-09T00:00:00Z');
146+
const createdBeforeDate: DateTime = dateTimeFromString(
147+
'2025-06-09T00:00:00Z'
148+
);
149+
const servers: Events = await client.events.getEvents({
150+
streamType: 'admin_logs' as GetEventsQueryParamsStreamTypeField,
151+
limit: 1,
152+
createdAfter: createdAfterDate,
153+
createdBefore: createdBeforeDate,
154+
} satisfies GetEventsQueryParams);
155+
if (!(servers.entries!.length == 1)) {
156+
throw new Error('Assertion failed');
157+
}
158+
});
140159
export {};

0 commit comments

Comments
 (0)