Workaround yarn workspace bug not creating app/node_modules/.bin link for react-scripts.

Author: bradfordlemley

packages/react-scripts/scripts/init.js

@@ -23,6 +23,7 @@ const { defaultBrowsers } = require('react-dev-utils/browsersHelper');
 const os = require('os');
 const resolveFrom = require('resolve-from');
 const paths = require('../config/paths');
+const { findMonorepo } = require('react-dev-utils/workspaceUtils');
 
 function isInGitRepository() {
   try {
@@ -177,10 +178,18 @@ module.exports = function(
     fs.unlinkSync(templateDependenciesPath);
   }
 
+  // yarn ws bug not creating app/node_modules/.bin link to hoisted react-scripts
+  // -- workaround: install react-scripts again to create link
+  // bug in yarn 1.3.2, fixed in nightly 1.4.1-20180211.2236
+  const rerunYarn = useYarn && findMonorepo(appPath).isAppIncluded;
+  if (rerunYarn) {
+    console.log('Detected app in yarn workspace, running install again');
+  }
+
   // Install react and react-dom for backward compatibility with old CRA cli
   // which doesn't install react and react-dom along with react-scripts
   // or template is presetend (via --internal-testing-template)
-  if (!isReactInstalled(appPackage) || template) {
+  if (!isReactInstalled(appPackage) || template || rerunYarn) {
     console.log(`Installing react and react-dom using ${command}...`);
     console.log();
 

tasks/e2e-monorepos.sh

@@ -126,7 +126,6 @@ popd
 pushd packages
 npx create-react-app newapp
 cd newapp
-yarn
 yarn build
 yarn start --smoke-test
 CI=true yarn test --watch=no
@@ -138,7 +137,6 @@ popd
 pushd packages
 npx create-react-app --internal-testing-template="$root_path"/packages/react-scripts/fixtures/monorepos/cra-app cra-app2
 cd cra-app2
-yarn
 verifyBuild
 yarn start --smoke-test
 verifyTest