test

Author: sunfishcode

tests/windows-open.rs

@@ -18,10 +18,15 @@ fn windows_open_one() {
 
     let dir = tmpdir.open_dir("aaa");
 
+    // Attempts to remove or rename the open directory should fail.
     tmpdir.remove_dir("aaa").unwrap_err();
     tmpdir.rename("aaa", &tmpdir, "zzz").unwrap_err();
 
     drop(dir);
+
+    // Now that we've droped the handle, the same operations should succeed.
+    check!(tmpdir.rename("aaa", &tmpdir, "xxx"));
+    check!(tmpdir.remove_dir("xxx"));
 }
 
 #[test]
@@ -32,10 +37,58 @@ fn windows_open_multiple() {
 
     let dir = tmpdir.open_dir("aaa/bbb");
 
+    // Attempts to remove or rename any component of the open directory should fail.
     tmpdir.remove_dir("aaa/bbb").unwrap_err();
     tmpdir.remove_dir("aaa").unwrap_err();
-    tmpdir.rename("aaa/bbb", &tmpdir, "aaa/zzz").unwrap_err();
+    tmpdir.rename("aaa/bbb", &tmpdir, "aaa/yyy").unwrap_err();
     tmpdir.rename("aaa", &tmpdir, "zzz").unwrap_err();
 
     drop(dir);
+
+    // Now that we've droped the handle, the same operations should succeed.
+    check!(tmpdir.rename("aaa/bbb", &tmpdir, "aaa/www"));
+    check!(tmpdir.rename("aaa", &tmpdir, "xxx"));
+    check!(tmpdir.remove_dir("xxx/www"));
+    check!(tmpdir.remove_dir("xxx"));
+}
+
+/// Like `windows_open_multiple`, but does so within a directory that we
+/// can close and then independently mutate.
+#[test]
+#[cfg(windows)]
+fn windows_open_tricky() {
+    let tmpdir = tmpdir();
+    check!(tmpdir.create_dir("qqq"));
+
+    let qqq = check!(tmpdir.open_dir("qqq"));
+    check!(qqq.create_dir_all("aaa/bbb"));
+
+    let dir = check!(qqq.open_dir("aaa/bbb"));
+
+    // Now drop `qqq`.
+    drop(qqq);
+
+    // Attempts to remove or rename any component of the open directory should fail.
+    dir.remove_dir("aaa/bbb").unwrap_err();
+    dir.remove_dir("aaa").unwrap_err();
+    dir.rename("aaa/bbb", &tmpdir, "aaa/yyy").unwrap_err();
+    dir.rename("aaa", &tmpdir, "zzz").unwrap_err();
+    tmpdir.remove_dir("qqq/aaa/bbb").unwrap_err();
+    tmpdir.remove_dir("qqq/aaa").unwrap_err();
+    tmpdir.remove_dir("qqq").unwrap_err();
+    tmpdir
+        .rename("qqq/aaa/bbb", &tmpdir, "qqq/aaa/yyy")
+        .unwrap_err();
+    tmpdir.rename("qqq/aaa", &tmpdir, "qqq/zzz").unwrap_err();
+    tmpdir.rename("qqq", &tmpdir, "vvv").unwrap_err();
+
+    drop(dir);
+
+    // Now that we've droped the handle, the same operations should succeed.
+    check!(tmpdir.rename("qqq/aaa/bbb", &tmpdir, "qqq/aaa/www"));
+    check!(tmpdir.rename("qqq/aaa", &tmpdir, "qqq/xxx"));
+    check!(tmpdir.rename("qqq", &tmpdir, "uuu"));
+    check!(tmpdir.remove_dir("uuu/xxx/www"));
+    check!(tmpdir.remove_dir("uuu/xxx"));
+    check!(tmpdir.remove_dir("uuu"));
 }