bug symfony#61 removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie (tinyroy)

This PR was merged into the 1.2-dev branch.

Discussion
----------

removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie

Fix symfony#25
Fix symfony#26

Commits
-------

dd1111e removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie

Author: nicolas-grekas

Factory/HttpFoundationFactory.php

@@ -140,14 +140,17 @@ protected function getTemporaryPath()
      */
     public function createResponse(ResponseInterface $psrResponse)
     {
+        $cookies = $psrResponse->getHeader('Set-Cookie');
+        $psrResponse = $psrResponse->withHeader('Set-Cookie', array());
+
         $response = new Response(
             $psrResponse->getBody()->__toString(),
             $psrResponse->getStatusCode(),
             $psrResponse->getHeaders()
         );
         $response->setProtocolVersion($psrResponse->getProtocolVersion());
 
-        foreach ($psrResponse->getHeader('Set-Cookie') as $cookie) {
+        foreach ($cookies as $cookie) {
             $response->headers->setCookie($this->createCookie($cookie));
         }
 

Tests/Fixtures/Message.php

@@ -64,7 +64,9 @@ public function getHeaderLine($name)
 
     public function withHeader($name, $value)
     {
-        throw new \BadMethodCallException('Not implemented.');
+        $this->headers[$name] = (array) $value;
+
+        return $this;
     }
 
     public function withAddedHeader($name, $value)