Skip to content

Commit b6b762e

Browse files
authored
Merge pull request symfony#9 from dunglas/remove-fix-command
Use Process's array syntax to remove hackish code
2 parents 2442374 + 8bcd51f commit b6b762e

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

src/ProcessManager/ChromeManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ final class ChromeManager implements BrowserManagerInterface
3131

3232
public function __construct(?string $chromeDriverBinary = null, ?array $arguments = null)
3333
{
34-
$this->process = new Process($this->fixCommand($chromeDriverBinary ?? $this->findChromeDriverBinary()), null, null, null, null);
34+
$this->process = new Process([$chromeDriverBinary ?? $this->findChromeDriverBinary()], null, null, null, null);
3535
$this->arguments = $arguments ?? $this->getDefaultArguments();
3636
}
3737

src/ProcessManager/WebServerReadinessProbeTrait.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,6 @@
2222
*/
2323
trait WebServerReadinessProbeTrait
2424
{
25-
/**
26-
* @see http://symfony.com/doc/current/components/process.html#process-signals
27-
*/
28-
private function fixCommand(string $command): string
29-
{
30-
if ('Windows' === PHP_OS_FAMILY || 'Darwin' === PHP_OS_FAMILY) {
31-
return $command;
32-
}
33-
34-
return "exec $command";
35-
}
36-
3725
/**
3826
* @throws \RuntimeException
3927
*/

0 commit comments

Comments
 (0)