aco/gfx11+: disable v_pk_fmac_f16_dpp

DadSchoorse · 1ace · commit ddb4aff2c2ce · 2024-02-14T17:01:47.000Z
Public docs are apparently wrong: llvm/llvm-project#79598 (comment) Cc: mesa-stable Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27533> (cherry picked from commit e927c50)
diff --git a/.pick_status.json b/.pick_status.json
@@ -2134,7 +2134,7 @@
         "description": "aco/gfx11+: disable v_pk_fmac_f16_dpp",
         "nominated": true,
         "nomination_type": 0,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": null,
         "notes": null
diff --git a/src/amd/compiler/aco_ir.cpp b/src/amd/compiler/aco_ir.cpp
@@ -414,6 +414,9 @@ can_use_DPP(amd_gfx_level gfx_level, const aco_ptr<Instruction>& instr, bool dpp
              instr->opcode == aco_opcode::v_dot2_f32_bf16;
    }
 
+   if (instr->opcode == aco_opcode::v_pk_fmac_f16)
+      return gfx_level < GFX11;
+
    /* there are more cases but those all take 64-bit inputs */
    return instr->opcode != aco_opcode::v_madmk_f32 && instr->opcode != aco_opcode::v_madak_f32 &&
           instr->opcode != aco_opcode::v_madmk_f16 && instr->opcode != aco_opcode::v_madak_f16 &&

Original file line number	Diff line number	Diff line change
`@@ -414,6 +414,9 @@ can_use_DPP(amd_gfx_level gfx_level, const aco_ptr<Instruction>& instr, bool dpp`
`414`	`414`	`instr->opcode == aco_opcode::v_dot2_f32_bf16;`
`415`	`415`	`}`
`416`	`416`
	`417`	`+ if (instr->opcode == aco_opcode::v_pk_fmac_f16)`
	`418`	`+ return gfx_level < GFX11;`
	`419`	`+`
`417`	`420`	`/* there are more cases but those all take 64-bit inputs */`
`418`	`421`	`return instr->opcode != aco_opcode::v_madmk_f32 && instr->opcode != aco_opcode::v_madak_f32 &&`
`419`	`422`	`instr->opcode != aco_opcode::v_madmk_f16 && instr->opcode != aco_opcode::v_madak_f16 &&`