Support standalone temporal AA on mobile platforms.

YOung · chenyong2github · commit 67b76784845a · 2022-09-25T11:22:19.000+08:00
diff --git a/Engine/Shaders/Private/PostProcessMobile.usf b/Engine/Shaders/Private/PostProcessMobile.usf
@@ -1180,13 +1180,22 @@ void AaVS_Mobile(
 	OutUV[3] = InTexCoord.xy + (Aa1 + float2( 0.0, 0.75)) * BufferSizeAndInvSize.zw;
 	OutUV[4] = InTexCoord.xy + (Aa1 + float2( 0.75, 0.0)) * BufferSizeAndInvSize.zw;
 	OutUV[5] = InTexCoord.xy + Aa2 * BufferSizeAndInvSize.zw;
+
+#if MOBILE_USE_STANDALONE_TAA
+	OutUV[2] = InTexCoord.xy;
+#endif
 }
 
 void AaPS_Mobile(
 	float2 UV[6] : TEXCOORD0,
 	out half4 OutColor : SV_Target0
 	)
 {
+#if MOBILE_USE_STANDALONE_TAA
+	OutColor = SceneColorTexture.Sample(SceneColorSampler, UV[2].xy);
+	return;
+#endif
+
 	//   N
 	// w M E            P = previous middle
 	//   S
diff --git a/Engine/Shaders/Private/TemporalAA/TAAStandalone.usf b/Engine/Shaders/Private/TemporalAA/TAAStandalone.usf
@@ -4,7 +4,11 @@
 
 #include "../Common.ush"
 #include "../Random.ush"
+
+#if FEATURE_LEVEL >= FEATURE_LEVEL_SM5
 #include "../EyeAdaptationCommon.ush"
+#endif
+
 #include "../TextureSampling.ush"
 #include "../MonteCarlo.ush"
 
@@ -2235,7 +2239,11 @@ void MainCS(
 	}
 	#endif
 
+#if FEATURE_LEVEL >= FEATURE_LEVEL_SM5
 	float FrameExposureScale = EyeAdaptationLookup();
+#else
+	float FrameExposureScale = 1;
+#endif
 	FTAAHistoryPayload OutputPayload = TemporalAASample(GroupId, GroupThreadId, GroupThreadIndex, ViewportUV, FrameExposureScale);
 
 	float4 OutColor0 = 0;
diff --git a/Engine/Source/Runtime/RenderCore/Private/RenderUtils.cpp b/Engine/Source/Runtime/RenderCore/Private/RenderUtils.cpp
@@ -1048,6 +1048,12 @@ RENDERCORE_API bool MobileSupportVolumetricFog(const FStaticShaderPlatform Platf
 	return (CVar && CVar->GetValueOnAnyThread() != 0) ? true : false;
 }
 
+RENDERCORE_API bool MobileUseStandaloneTAA(const FStaticShaderPlatform Platform)
+{
+	static TConsoleVariableData<int32>* CVar = IConsoleManager::Get().FindTConsoleVariableDataInt(TEXT("r.Mobile.UseStandaloneTAA"));
+	return (CVar && CVar->GetValueOnAnyThread() != 0) ? true : false;
+}
+
 RENDERCORE_API int32 GUseForwardShading = 0;
 static FAutoConsoleVariableRef CVarForwardShading(
 	TEXT("r.ForwardShading"),
diff --git a/Engine/Source/Runtime/RenderCore/Public/RenderUtils.h b/Engine/Source/Runtime/RenderCore/Public/RenderUtils.h
@@ -488,6 +488,8 @@ RENDERCORE_API bool AllowScreenSpaceReflection(const FStaticShaderPlatform Platf
 
 RENDERCORE_API bool MobileSupportVolumetricFog(const FStaticShaderPlatform Platform);
 
+RENDERCORE_API bool MobileUseStandaloneTAA(const FStaticShaderPlatform Platform);
+
 /** Returns if ForwardShading is enabled. Only valid for the current platform (otherwise call ITargetPlatform::UsesForwardShading()). */
 inline bool IsForwardShadingEnabled(const FStaticShaderPlatform Platform)
 {
diff --git a/Engine/Source/Runtime/Renderer/Private/PostProcess/PostProcessMobile.cpp b/Engine/Source/Runtime/Renderer/Private/PostProcess/PostProcessMobile.cpp
@@ -1743,6 +1743,9 @@ class FMobileTAAPS : public FGlobalShader
 	DECLARE_GLOBAL_SHADER(FMobileTAAPS);
 	SHADER_USE_PARAMETER_STRUCT(FMobileTAAPS, FGlobalShader);
 
+	class FUseStandaloneTAA : SHADER_PERMUTATION_BOOL("MOBILE_USE_STANDALONE_TAA");
+	using FPermutationDomain = TShaderPermutationDomain<FUseStandaloneTAA>;
+
 	BEGIN_SHADER_PARAMETER_STRUCT(FParameters, )
 		SHADER_PARAMETER_STRUCT_REF(FViewUniformShaderParameters, View)
 		SHADER_PARAMETER(float, AaBlendAmount)
@@ -1757,6 +1760,13 @@ class FMobileTAAPS : public FGlobalShader
 	{
 		return IsMobilePlatform(Parameters.Platform);
 	}
+
+	static FPermutationDomain BuildPermutationVector(bool bUseStandaloneTAA)
+	{
+		FPermutationDomain PermutationVector;
+		PermutationVector.Set<FUseStandaloneTAA>(bUseStandaloneTAA);
+		return PermutationVector;
+	}
 };
 
 IMPLEMENT_GLOBAL_SHADER(FMobileTAAPS, "/Engine/Private/PostProcessMobile.usf", "AaPS_Mobile", SF_Pixel);
@@ -1767,6 +1777,9 @@ class FMobileTAAVS : public FGlobalShader
 	DECLARE_GLOBAL_SHADER(FMobileTAAVS);
 	SHADER_USE_PARAMETER_STRUCT_WITH_LEGACY_BASE(FMobileTAAVS, FGlobalShader);
 
+	class FUseStandaloneTAA : SHADER_PERMUTATION_BOOL("MOBILE_USE_STANDALONE_TAA");
+	using FPermutationDomain = TShaderPermutationDomain<FUseStandaloneTAA>;
+
 	BEGIN_SHADER_PARAMETER_STRUCT(FParameters, )
 		SHADER_PARAMETER_STRUCT_REF(FViewUniformShaderParameters, View)
 		SHADER_PARAMETER(FVector4, BufferSizeAndInvSize)
@@ -1776,6 +1789,13 @@ class FMobileTAAVS : public FGlobalShader
 	{
 		return IsMobilePlatform(Parameters.Platform);
 	}
+
+	static FPermutationDomain BuildPermutationVector(bool bUseStandaloneTAA)
+	{
+		FPermutationDomain PermutationVector;
+		PermutationVector.Set<FUseStandaloneTAA>(bUseStandaloneTAA);
+		return PermutationVector;
+	}
 };
 
 IMPLEMENT_GLOBAL_SHADER(FMobileTAAVS, "/Engine/Private/PostProcessMobile.usf", "AaVS_Mobile", SF_Vertex);
@@ -1793,7 +1813,9 @@ FScreenPassTexture AddMobileTAAPass(FRDGBuilder& GraphBuilder, const FViewInfo&
 		TAAOutput = FScreenPassRenderTarget(GraphBuilder.CreateTexture(TAADesc, TEXT("TAA")), Inputs.SceneColor.ViewRect, View.IsFirstInFamily() ? ERenderTargetLoadAction::EClear : ERenderTargetLoadAction::ELoad);
 	}
 
-	TShaderMapRef<FMobileTAAVS> VertexShader(View.ShaderMap);
+	auto VSShaderPermutationVector = FMobileTAAVS::BuildPermutationVector(Inputs.bUseStandaloneTAA);
+	TShaderMapRef<FMobileTAAVS> VertexShader(View.ShaderMap, VSShaderPermutationVector);
+
 
 	FMobileTAAVS::FParameters VSShaderParameters;
 
@@ -1857,7 +1879,8 @@ FScreenPassTexture AddMobileTAAPass(FRDGBuilder& GraphBuilder, const FViewInfo&
 		}
 	}
 
-	TShaderMapRef<FMobileTAAPS> PixelShader(View.ShaderMap);
+	auto PSShaderPermutationVector = FMobileTAAPS::BuildPermutationVector(Inputs.bUseStandaloneTAA);
+	TShaderMapRef<FMobileTAAPS> PixelShader(View.ShaderMap, PSShaderPermutationVector);
 
 	FMobileTAAPS::FParameters* PSShaderParameters = GraphBuilder.AllocParameters<FMobileTAAPS::FParameters>();
 	PSShaderParameters->RenderTargets[0] = TAAOutput.GetRenderTargetBinding();
diff --git a/Engine/Source/Runtime/Renderer/Private/PostProcess/PostProcessMobile.h b/Engine/Source/Runtime/Renderer/Private/PostProcess/PostProcessMobile.h
@@ -165,6 +165,8 @@ struct FMobileTAAInputs
 	FScreenPassRenderTarget OverrideOutput;
 	FScreenPassTexture SceneColor;
 	FScreenPassTexture LastFrameSceneColor;
+
+	bool bUseStandaloneTAA = false;
 };
 
 FScreenPassTexture AddMobileTAAPass(FRDGBuilder& GraphBuilder, const FViewInfo& View, const FMobileTAAInputs& Inputs);
diff --git a/Engine/Source/Runtime/Renderer/Private/PostProcess/PostProcessing.cpp b/Engine/Source/Runtime/Renderer/Private/PostProcess/PostProcessing.cpp
@@ -97,6 +97,14 @@ TAutoConsoleVariable<int32> CVarPostProcessingForceAsyncDispatch(
 	TEXT("Only available for testing in non-shipping builds."),
 	ECVF_RenderThreadSafe);
 #endif
+
+TAutoConsoleVariable<int32> CVarMobileUseStandaloneTAA(
+	TEXT("r.Mobile.UseStandaloneTAA"),
+	0,
+	TEXT("Whether to use standalone temporal AA on mobile platforms."),
+	ECVF_Scalability | ECVF_RenderThreadSafe
+);
+
 } //! namespace
 
 bool IsPostProcessingWithComputeEnabled(ERHIFeatureLevel::Type FeatureLevel)
@@ -1970,7 +1978,49 @@ void AddMobilePostProcessingPasses(FRDGBuilder& GraphBuilder, const FViewInfo& V
 				GraphBuilder.QueueTextureExtraction(SceneColor.Texture, &View.ViewState->PrevFrameViewInfo.MobileAaColor);
 			}
 
+			bool bUseStandaloneTAA = MobileUseStandaloneTAA(View.GetShaderPlatform());
+			if (bUseStandaloneTAA)
+			{
+				int32 UpscaleMode = ITemporalUpscaler::GetTemporalUpscalerMode();
+
+				const ITemporalUpscaler* DefaultTemporalUpscaler = ITemporalUpscaler::GetDefaultTemporalUpscaler();
+				const ITemporalUpscaler* UpscalerToUse = (UpscaleMode == 0 || !View.Family->GetTemporalUpscalerInterface()) ? DefaultTemporalUpscaler : View.Family->GetTemporalUpscalerInterface();
+
+				const TCHAR* UpscalerName = UpscalerToUse->GetDebugName();
+
+				// Standard event scope for temporal upscaler to have all profiling information not matter what, and with explicit detection of third party.
+				RDG_EVENT_SCOPE_CONDITIONAL(
+					GraphBuilder,
+					UpscalerToUse != DefaultTemporalUpscaler,
+					"ThirdParty %s %dx%d -> %dx%d",
+					UpscalerToUse->GetDebugName(),
+					View.ViewRect.Width(), View.ViewRect.Height(),
+					View.GetSecondaryViewRectSize().X, View.GetSecondaryViewRectSize().Y);
+
+				ITemporalUpscaler::FPassInputs UpscalerPassInputs;
+
+				UpscalerPassInputs.bAllowDownsampleSceneColor = false;
+				UpscalerPassInputs.DownsampleOverrideFormat = PF_FloatRGB;
+				UpscalerPassInputs.SceneColorTexture = SceneColor.Texture;
+				UpscalerPassInputs.SceneDepthTexture = SceneDepth.Texture;
+				UpscalerPassInputs.SceneVelocityTexture = GSystemTextures.GetBlackDummy(GraphBuilder);
+				UpscalerPassInputs.EyeAdaptationTexture = GetEyeAdaptationTexture(GraphBuilder, View);
+
+				FScreenPassTexture HalfResolutionSceneColor;
+				FIntRect SecondaryViewRect = View.ViewRect;
+
+				UpscalerToUse->AddPasses(
+					GraphBuilder,
+					View,
+					UpscalerPassInputs,
+					&SceneColor.Texture,
+					&SecondaryViewRect,
+					&HalfResolutionSceneColor.Texture,
+					&HalfResolutionSceneColor.ViewRect);
+			}
+
 			FMobileTAAInputs TAAInputs;
+			TAAInputs.bUseStandaloneTAA = bUseStandaloneTAA;
 			PassSequence.AcceptOverrideIfLastPass(EPass::TAA, TAAInputs.OverrideOutput);
 			TAAInputs.OverrideOutput.LoadAction = View.IsFirstInFamily() ? ERenderTargetLoadAction::EClear : ERenderTargetLoadAction::ELoad;
 			TAAInputs.SceneColor = SceneColor;
diff --git a/Engine/Source/Runtime/Renderer/Private/PostProcess/TemporalAA.cpp b/Engine/Source/Runtime/Renderer/Private/PostProcess/TemporalAA.cpp
@@ -294,7 +294,7 @@ class FTAAStandaloneCS : public FGlobalShader
 			return false;
 		}
 
-		return IsFeatureLevelSupported(Parameters.Platform, ERHIFeatureLevel::SM5);
+		return IsFeatureLevelSupported(Parameters.Platform, ERHIFeatureLevel::ES3_1);
 	}
 
 	static void ModifyCompilationEnvironment(const FGlobalShaderPermutationParameters& Parameters, FShaderCompilerEnvironment& OutEnvironment)

Original file line number	Diff line number	Diff line change
`@@ -488,6 +488,8 @@ RENDERCORE_API bool AllowScreenSpaceReflection(const FStaticShaderPlatform Platf`
`488`	`488`
`489`	`489`	`RENDERCORE_API bool MobileSupportVolumetricFog(const FStaticShaderPlatform Platform);`
`490`	`490`
	`491`	`+RENDERCORE_API bool MobileUseStandaloneTAA(const FStaticShaderPlatform Platform);`
	`492`	`+`
`491`	`493`	`/** Returns if ForwardShading is enabled. Only valid for the current platform (otherwise call ITargetPlatform::UsesForwardShading()). */`
`492`	`494`	`inline bool IsForwardShadingEnabled(const FStaticShaderPlatform Platform)`
`493`	`495`	`{`
Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ class FTAAStandaloneCS : public FGlobalShader`
`294`	`294`	`return false;`
`295`	`295`	`}`
`296`	`296`
`297`		`- return IsFeatureLevelSupported(Parameters.Platform, ERHIFeatureLevel::SM5);`
	`297`	`+ return IsFeatureLevelSupported(Parameters.Platform, ERHIFeatureLevel::ES3_1);`
`298`	`298`	`}`
`299`	`299`
`300`	`300`	`static void ModifyCompilationEnvironment(const FGlobalShaderPermutationParameters& Parameters, FShaderCompilerEnvironment& OutEnvironment)`