Merge pull request #197 from elezar/add-error-to-configure

klihub · web-flow · commit 780f60f5e4ac · 2024-03-16T17:07:15.000+02:00
Allow top-level Configure to return an error
diff --git a/pkg/cdi/default-cache.go b/pkg/cdi/default-cache.go
@@ -44,12 +44,12 @@ func GetDefaultCache() *Cache {
 
 // Configure applies options to the default CDI cache. Updates and refreshes
 // the default cache if options are not empty.
-func Configure(options ...Option) {
+func Configure(options ...Option) error {
 	cache, created := getOrCreateDefaultCache(options...)
 	if len(options) == 0 || created {
-		return
+		return nil
 	}
-	cache.Configure(options...)
+	return cache.Configure(options...)
 }
 
 // Refresh explicitly refreshes the default CDI cache instance.

Original file line number	Diff line number	Diff line change
`@@ -44,12 +44,12 @@ func GetDefaultCache() *Cache {`
`44`	`44`
`45`	`45`	`// Configure applies options to the default CDI cache. Updates and refreshes`
`46`	`46`	`// the default cache if options are not empty.`
`47`		`-func Configure(options ...Option) {`
	`47`	`+func Configure(options ...Option) error {`
`48`	`48`	`cache, created := getOrCreateDefaultCache(options...)`
`49`	`49`	`if len(options) == 0 \|\| created {`
`50`		`- return`
	`50`	`+ return nil`
`51`	`51`	`}`
`52`		`- cache.Configure(options...)`
	`52`	`+ return cache.Configure(options...)`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`// Refresh explicitly refreshes the default CDI cache instance.`