Skip to content

Commit 6bd43c3

Browse files
committed
keep file/directory permissions in Reproducible Builds mode
1 parent 0cffff5 commit 6bd43c3

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

src/main/java/org/codehaus/plexus/archiver/AbstractArchiver.java

+1-6
Original file line numberDiff line numberDiff line change
@@ -1283,12 +1283,7 @@ public void configureReproducibleBuild( FileTime lastModifiedTime )
12831283
// 2. sort filenames in each directory when scanning filesystem
12841284
setFilenameComparator( String::compareTo );
12851285

1286-
// 3. ignore file/directory mode from filesystem, since they may vary based on local user umask
1287-
// notice: this overrides execute bit on Unix (that is already ignored on Windows)
1288-
setFileMode( Archiver.DEFAULT_FILE_MODE );
1289-
setDirectoryMode( Archiver.DEFAULT_DIR_MODE );
1290-
1291-
// 4. ignore uid/gid from filesystem (for tar)
1286+
// 3. ignore uid/gid from filesystem (for tar)
12921287
setOverrideUid( 0 );
12931288
setOverrideUserName( "root" ); // is it possible to avoid this, like "tar --numeric-owner"?
12941289
setOverrideGid( 0 );

src/main/java/org/codehaus/plexus/archiver/Archiver.java

-1
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,6 @@ ResourceIterator getResources()
488488
* <ul>
489489
* <li>reproducible archive entries order,</li>
490490
* <li>defined entries timestamp</li>
491-
* <li>and reproducible entries Unix mode.</li>
492491
* </ul>
493492
*
494493
* @param lastModifiedTime The last modification time of the entries

0 commit comments

Comments
 (0)