Skip to content

Commit 79199e4

Browse files
authored
make java 11 as project base but keep javac release 8, we will be able to upgrade ecj and errorprone (#186)
* make java 11 as project base but keep javac release flag to 8, we will be able to upgrade ecj and errorprone Signed-off-by: Olivier Lamy <[email protected]>
1 parent bc74ba0 commit 79199e4

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

.github/workflows/maven.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ jobs:
2727

2828
build:
2929
name: Build it
30-
uses: codehaus-plexus/.github/.github/workflows/maven.yml@v0.0.1
30+
uses: codehaus-plexus/.github/.github/workflows/maven.yml@master
3131
with:
32-
jdk-matrix: '["8", "11", "17"]'
33-
jdk-distribution-matrix: '["zulu", "temurin"]'
32+
jdk-fast-fail-build: '11'
33+
jdk-matrix: '["11", "17"]'
34+
jdk-distribution-matrix: '["zulu", "temurin", "microsoft", "liberica"]'
3435
os-matrix: '["ubuntu-latest","windows-latest", "macOS-latest"]'
3536
maven_args: 'verify javadoc:javadoc -e -B -V -fae -Pno-tests-if-not-on-osx'
3637

pom.xml

+10-4
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<connection>${scm.url}</connection>
2929
<developerConnection>${scm.url}</developerConnection>
3030
<url>http://github.com/codehaus-plexus/plexus-compiler/tree/${project.scm.tag}/</url>
31-
<tag>master</tag>
3231
</scm>
3332
<issueManagement>
3433
<system>github</system>
@@ -43,7 +42,7 @@
4342

4443
<properties>
4544
<scm.url>scm:git:[email protected]:codehaus-plexus/plexus-compiler.git</scm.url>
46-
<javaVersion>8</javaVersion>
45+
<javaVersion>11</javaVersion>
4746
<redirectTestOutputToFile>true</redirectTestOutputToFile>
4847
<project.build.outputTimestamp>2021-10-18T08:22:06Z</project.build.outputTimestamp>
4948
<jupiter.version>5.8.2</jupiter.version>
@@ -121,6 +120,13 @@
121120
<redirectTestOutputToFile>${redirectTestOutputToFile}</redirectTestOutputToFile>
122121
</configuration>
123122
</plugin>
123+
<plugin>
124+
<groupId>org.apache.maven.plugins</groupId>
125+
<artifactId>maven-compiler-plugin</artifactId>
126+
<configuration>
127+
<release>8</release>
128+
</configuration>
129+
</plugin>
124130
<plugin>
125131
<groupId>org.apache.maven.plugins</groupId>
126132
<artifactId>maven-release-plugin</artifactId>
@@ -192,8 +198,8 @@
192198
<configuration>
193199
<rules>
194200
<requireJavaVersion>
195-
<version>[1.8,)</version>
196-
<message>[ERROR] OLD JDK [${java.version}] in use. This projects requires JDK 8 or newer</message>
201+
<version>[11,)</version>
202+
<message>[ERROR] OLD JDK [${java.version}] in use. This projects requires JDK 11 or newer</message>
197203
</requireJavaVersion>
198204
</rules>
199205
</configuration>

0 commit comments

Comments
 (0)