Skip to content

Commit e16dc59

Browse files
committed
Reducing number of classes; No singleton but static.
Signed-off-by: Markus KARG <[email protected]>
1 parent bc5b0ab commit e16dc59

File tree

5 files changed

+34
-41
lines changed

5 files changed

+34
-41
lines changed

src/main/java/org/codehaus/plexus/util/CommonImplementation.java

-29
This file was deleted.

src/main/java/org/codehaus/plexus/util/IOUtil.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ private IOUtil()
156156
public static void copy( final InputStream input, final OutputStream output )
157157
throws IOException
158158
{
159-
VersionSpecifics.INSTANCE.copy( input, output );
159+
VersionSpecifics.copy( input, output );
160160
}
161161

162162
/**
@@ -186,7 +186,7 @@ public static void copy( final InputStream input, final OutputStream output, fin
186186
public static void copy( final Reader input, final Writer output )
187187
throws IOException
188188
{
189-
VersionSpecifics.INSTANCE.copy( input, output );
189+
VersionSpecifics.copy( input, output );
190190
}
191191

192192
/**
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,31 @@
11
package org.codehaus.plexus.util;
22

3+
import java.io.IOException;
4+
import java.io.InputStream;
5+
import java.io.OutputStream;
6+
import java.io.Reader;
7+
import java.io.Writer;
8+
39
/**
410
* Implementation specific to Java SE 8 version.
511
*/
6-
final class VersionSpecifics extends CommonImplementation
12+
final class VersionSpecifics
713
{
8-
static final VersionSpecifics INSTANCE = new VersionSpecifics();
14+
private static final int DEFAULT_BUFFER_SIZE = 1024 * 16;
915

1016
private VersionSpecifics() {
1117
// singleton
1218
}
19+
20+
static void copy( final InputStream input, final OutputStream output )
21+
throws IOException
22+
{
23+
IOUtil.copy( input, output, DEFAULT_BUFFER_SIZE );
24+
}
25+
26+
static void copy( final Reader input, final Writer output )
27+
throws IOException
28+
{
29+
IOUtil.copy( input, output, DEFAULT_BUFFER_SIZE );
30+
}
1331
}

src/main/java10/org/codehaus/plexus/util/VersionSpecifics.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,19 @@
99
/**
1010
* Implementation specific to Java SE 10 version.
1111
*/
12-
final class VersionSpecifics extends CommonImplementation
12+
final class VersionSpecifics
1313
{
14-
static final VersionSpecifics INSTANCE = new VersionSpecifics();
15-
1614
private VersionSpecifics() {
1715
// singleton
1816
}
1917

20-
void copy( final InputStream input, final OutputStream output )
18+
static void copy( final InputStream input, final OutputStream output )
2119
throws IOException
2220
{
2321
input.transferTo( output );
2422
}
2523

26-
void copy( final Reader input, final Writer output )
24+
static void copy( final Reader input, final Writer output )
2725
throws IOException
2826
{
2927
input.transferTo( output );

src/main/java9/org/codehaus/plexus/util/VersionSpecifics.java

+9-3
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,23 @@
99
/**
1010
* Implementation specific to Java SE 9 version.
1111
*/
12-
final class VersionSpecifics extends CommonImplementation
12+
final class VersionSpecifics
1313
{
14-
static final VersionSpecifics INSTANCE = new VersionSpecifics();
14+
private static final int DEFAULT_BUFFER_SIZE = 1024 * 16;
1515

1616
private VersionSpecifics() {
1717
// singleton
1818
}
1919

20-
void copy( final InputStream input, final OutputStream output )
20+
static void copy( final InputStream input, final OutputStream output )
2121
throws IOException
2222
{
2323
input.transferTo( output );
2424
}
25+
26+
static void copy( final Reader input, final Writer output )
27+
throws IOException
28+
{
29+
IOUtil.copy( input, output, DEFAULT_BUFFER_SIZE );
30+
}
2531
}

0 commit comments

Comments
 (0)