Skip to content

feat: Queue::push() to return job ID instead of boolean #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

michalsn
Copy link
Member

Description
This PR updates the push() method to return the unique job ID of the queued job instead of a simple bool. This allows consumers to track jobs based on their identifier.

  • Queue::push() now returns a string (job ID) on success or null on failure
  • Method signature updated from bool to ?string
  • This is a breaking change in method behavior

Closes #61

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

coveralls commented May 30, 2025

Pull Request Test Coverage Report for Build 15340617597

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.318%

Totals Coverage Status
Change from base Build 14830363870: 0.03%
Covered Lines: 685
Relevant Lines: 742

💛 - Coveralls

@michalsn michalsn added the enhancement New feature or request label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

push should return row id of the new inserted job?
2 participants