Use separate data directories for unit test instances

Exactly as we do for the e2e tests.

Author: code-asher

package.json

@@ -158,6 +158,7 @@
     ],
     "moduleNameMapper": {
       "^.+\\.(css|less)$": "<rootDir>/test/utils/cssStub.ts"
-    }
+    },
+    "globalSetup": "<rootDir>/test/utils/globalUnitSetup.ts"
   }
 }

test/playwright.config.ts

@@ -12,7 +12,7 @@ const config: PlaywrightTestConfig = {
   testDir: path.join(__dirname, "e2e"), // Search for tests in this directory.
   timeout: 60000, // Each test is given 60 seconds.
   retries: process.env.CI ? 2 : 1, // Retry in CI due to flakiness.
-  globalSetup: require.resolve("./utils/globalSetup.ts"),
+  globalSetup: require.resolve("./utils/globalE2eSetup.ts"),
   reporter: "list",
   // Put any shared options on the top level.
   use: {

test/utils/globalSetup.ts renamed to test/utils/globalE2eSetup.ts

@@ -6,8 +6,8 @@ import { clean } from "./helpers"
 import * as wtfnode from "./wtfnode"
 
 /**
- * Perform workspace cleanup and authenticate. This should be set up to run
- * before our tests execute.
+ * Perform workspace cleanup and authenticate. This should be ran before e2e
+ * tests execute.
  */
 export default async function () {
   console.log("\n🚨 Running Global Setup for Playwright End-to-End Tests")

test/utils/globalUnitSetup.ts

@@ -0,0 +1,9 @@
+import { workspaceDir } from "./constants"
+import { clean } from "./helpers"
+
+/**
+ * Perform workspace cleanup. This should be ran before unit tests execute.
+ */
+export default async function () {
+  await clean(workspaceDir)
+}

test/utils/integration.ts

@@ -1,11 +1,27 @@
+import { promises as fs } from "fs"
+import * as path from "path"
 import { parse, parseConfigFile, setDefaults } from "../../src/node/cli"
 import { runCodeServer } from "../../src/node/main"
+import { workspaceDir } from "./constants"
+import { tmpdir } from "./helpers"
 import * as httpserver from "./httpserver"
 
 export async function setup(argv: string[], configFile?: string): Promise<httpserver.HttpServer> {
-  argv = ["--bind-addr=localhost:0", "--log=warn", ...argv]
+  // This will be used as the data directory to ensure instances do not bleed
+  // into each other.
+  const dir = await tmpdir(workspaceDir)
 
-  const cliArgs = parse(argv)
+  // VS Code complains if the logs dir is missing which spams the output.
+  // TODO: Does that mean we are not creating it when we should be?
+  await fs.mkdir(path.join(dir, "logs"))
+
+  const cliArgs = parse([
+    `--config=${path.join(dir, "config.yaml")}`,
+    `--user-data-dir=${dir}`,
+    "--bind-addr=localhost:0",
+    "--log=warn",
+    ...argv,
+  ])
   const configArgs = parseConfigFile(configFile || "", "test/integration.ts")
   const args = await setDefaults(cliArgs, configArgs)