Skip to content

Commit 40d0c88

Browse files
committed
fix: extHostExtensionService
Looks like they modified the function signature for _loadCommonJSModule. I believe the first param is now the extensionId or null. Probably for logging reason guessing.
1 parent 2bd9b6e commit 40d0c88

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

lib/vscode/src/vs/workbench/api/common/extHostExtensionService.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -369,11 +369,7 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
369369

370370
const activationTimesBuilder = new ExtensionActivationTimesBuilder(reason.startup);
371371
return Promise.all([
372-
<<<<<<< HEAD
373-
this._loadCommonJSModule<IExtensionModule>(joinPath(extensionDescription.extensionLocation, entryPoint), activationTimesBuilder, !extensionDescription.browser),
374-
=======
375372
this._loadCommonJSModule<IExtensionModule>(extensionDescription.identifier, joinPath(extensionDescription.extensionLocation, entryPoint), activationTimesBuilder),
376-
>>>>>>> 89b6e0164fa770333755b11504e19a4232b1a2d4
377373
this._loadExtensionContext(extensionDescription)
378374
]).then(values => {
379375
performance.mark(`code/extHost/willActivateExtension/${extensionDescription.identifier.value}`);
@@ -783,11 +779,7 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
783779

784780
protected abstract _beforeAlmostReadyToRunExtensions(): Promise<void>;
785781
protected abstract _getEntryPoint(extensionDescription: IExtensionDescription): string | undefined;
786-
<<<<<<< HEAD
787-
protected abstract _loadCommonJSModule<T>(module: URI, activationTimesBuilder: ExtensionActivationTimesBuilder, isRemote?: boolean): Promise<T>;
788-
=======
789782
protected abstract _loadCommonJSModule<T>(extensionId: ExtensionIdentifier | null, module: URI, activationTimesBuilder: ExtensionActivationTimesBuilder): Promise<T>;
790-
>>>>>>> 89b6e0164fa770333755b11504e19a4232b1a2d4
791783
public abstract $setRemoteEnvironment(env: { [key: string]: string | null }): Promise<void>;
792784
}
793785

0 commit comments

Comments
 (0)