Skip to content

Commit 8ed83cb

Browse files
committed
Use frozen lockfile for test dependencies in CI
This might be causing more Playwright issues.
1 parent dcc9cf3 commit 8ed83cb

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

ci/dev/postinstall.sh

+15-14
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,28 @@ main() {
66

77
echo "Installing code-server test dependencies..."
88

9+
local args=(install)
10+
if [[ ${CI-} ]]; then
11+
args+=(--frozen-lockfile)
12+
fi
13+
914
cd test
10-
yarn install
15+
yarn "${args[@]}"
1116
cd ..
1217

1318
cd vendor
1419
echo "Installing vendor dependencies..."
1520

16-
# * We install in 'modules' instead of 'node_modules' because VS Code's extensions
17-
# use a webpack config which cannot differentiate between its own node_modules
18-
# and itself being in a directory with the same name.
19-
#
20-
# * We ignore scripts because NPM/Yarn's default behavior is to assume that
21-
# devDependencies are not needed, and that even git repo based packages are
22-
# assumed to be compiled. Because the default behavior for VS Code's `postinstall`
23-
# assumes we're also compiled, this needs to be ignored.
21+
# We install in 'modules' instead of 'node_modules' because VS Code's
22+
# extensions use a webpack config which cannot differentiate between its own
23+
# node_modules and itself being in a directory with the same name.
24+
args+=(--modules-folder modules)
2425

25-
local args=(install --modules-folder modules --ignore-scripts)
26-
27-
if [[ ${CI-} ]]; then
28-
args+=("--frozen-lockfile")
29-
fi
26+
# We ignore scripts because NPM/Yarn's default behavior is to assume that
27+
# devDependencies are not needed, and that even git repo based packages are
28+
# assumed to be compiled. Because the default behavior for VS Code's
29+
# `postinstall` assumes we're also compiled, this needs to be ignored.
30+
args+=(--ignore-scripts)
3031

3132
yarn "${args[@]}"
3233

0 commit comments

Comments
 (0)