wip: try out new approach

Author: jsjoeio

.github/workflows/ci.yaml

@@ -188,6 +188,13 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
+      # NOTES@jsjoeio - trying out
+      - uses: actions/download-artifact@v2
+        id: download
+        with:
+          name: "npm-package"
+          path: tmp-npm-package-dir
+
       - name:
           Set NPM_ENVIRONMENT
           # The way this logic works is it checks if the GitHub event is a push to the `main` branch

ci/lib.sh

@@ -130,8 +130,7 @@ download_artifact() {
   local artifacts_url
   artifacts_url="$(get_artifact_url "$artifact_name" "$environment" "$branch")"
 
-  echo "Inside download_artifact"
-  echo "Using the following values:"
+  echo "Using the following values to download artifact:"
   echo "-artifact_name: $artifact_name"
   echo "-dst: $dst"
   echo "-environment: $environment"

ci/steps/publish-npm.sh

@@ -76,7 +76,11 @@ main() {
   # Source:https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables
   BRANCH="${GITHUB_HEAD_REF-main}"
   echo "Calling download_artifact with npm env: $NPM_ENVIRONMENT and branch: $BRANCH"
-  download_artifact npm-package ./release-npm-package "$NPM_ENVIRONMENT" "$BRANCH"
+  # download_artifact npm-package ./release-npm-package "$NPM_ENVIRONMENT" "$BRANCH"
+  # NOTES@jsjoeio testing an approach where we run this script after downloading the artifact
+  # in a job in the workflow file itself
+  unzip -q -o "tmp-npm-package-dir" -d "./release-npm-package"
+
   # https://github.com/actions/upload-artifact/issues/38
   tar -xzf release-npm-package/package.tar.gz