refactor(article-tags): remove old tags system

Author: mydearxym

cover/excoveralls.json

@@ -1,4 +1,3 @@
-
 ### 单元测试
 
 单元测试部分全部位于 `test/groupher_server/` 目录下, 按照接口的 Context 分为
@@ -7,13 +6,13 @@
 accounts   billing    cms        delivery   logs       seeds      statistics
 ```
 
-> Phoenix 使用 ExUnit(link) 作为测试模块，测试文件必须以 '_test.exs' 作为结尾，否则会被忽略。
+> Phoenix 使用 ExUnit(link) 作为测试模块，测试文件必须以 '\_test.exs' 作为结尾，否则会被忽略。
 
 #### 运行测试
 
 在项目根目录执行 `make test` 即可运行所有测试, 你也可以使用 `make test.watch` 或
 `make test.watch.wip` 以 watch mode 运行全部或其中一部分测试。 更多命令可以使用
-`make test.help` 查看: 
+`make test.help` 查看:
 
 ```text
 
@@ -38,7 +37,7 @@ accounts   billing    cms        delivery   logs       seeds      statistics
 
 #### Helper 函数
 
-以一个实际例子作为说明: 
+以一个实际例子作为说明:
 
 ```elixir
 defmodule GroupherServer.Test.CMS do
@@ -60,9 +59,9 @@ defmodule GroupherServer.Test.CMS do
 
   describe "[cms tag]" do
     test "create tag with valid data", ~m(community user)a do
-      valid_attrs = mock_attrs(:tag)
+      valid_attrs = mock_attrs(:article_tag)
 
-      {:ok, tag} = CMS.create_tag(community, :post, valid_attrs, %User{id: user.id})
+      {:ok, tag} = CMS.create_article_tag(community, :post, valid_attrs, %User{id: user.id})
       assert tag.title == valid_attrs.title
     end
   end
@@ -81,8 +80,3 @@ use GroupherServer.TestTools
 3. 这里测试的都是 `lib/groupher_server` 下的模块，不涉及 Graphql
 
 4. 更多的技巧你可以参照文档或现有的测试用例，通常它们都浅显易懂。
-
-
-
-
-

docs/testing/unit-testing.zh-CN.md

@@ -13,7 +13,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
   alias Helper.Types, as: T
   alias Helper.ORM
 
-  alias GroupherServer.CMS.{Embeds, Community, Tag, PinnedArticle}
+  alias GroupherServer.CMS.{Embeds, Community, PinnedArticle}
   alias GroupherServer.Repo
 
   alias Ecto.Multi
@@ -128,47 +128,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
   defp result({:ok, %{mirror_target_community: result}}), do: result |> done()
   defp result({:error, _, result, _steps}), do: {:error, result}
 
-  @doc """
-  set general tag for post / tuts ...
-  """
-  # check community first
-  def set_tag(thread, %Tag{id: tag_id}, content_id) do
-    with {:ok, action} <- match_action(thread, :tag),
-         {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
-         {:ok, tag} <- ORM.find(action.reactor, tag_id) do
-      update_content_tag(content, tag)
-
-      # NOTE: this should be control by Middleware
-      # case tag_in_community_thread?(%Community{id: communitId}, thread, tag) do
-      # true ->
-      # content
-      # |> Ecto.Changeset.change()
-      # |> Ecto.Changeset.put_assoc(:tags, content.tags ++ [tag])
-      # |> Repo.update()
-
-      # _ ->
-      # {:error, message: "Tag,Community,Thread not match", code: ecode(:custom)}
-      # end
-    end
-  end
-
-  def unset_tag(thread, %Tag{id: tag_id}, content_id) do
-    with {:ok, action} <- match_action(thread, :tag),
-         {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
-         {:ok, tag} <- ORM.find(action.reactor, tag_id) do
-      update_content_tag(content, tag, :drop)
-    end
-  end
-
-  defp update_content_tag(content, %Tag{} = tag, opt \\ :add) do
-    new_tags = if opt == :add, do: content.tags ++ [tag], else: content.tags -- [tag]
-
-    content
-    |> Ecto.Changeset.change()
-    |> Ecto.Changeset.put_assoc(:tags, new_tags)
-    |> Repo.update()
-  end
-
   @doc "update isEdited meta label if needed"
   # TODO: diff history
   def update_edit_status(%{meta: %Embeds.ArticleMeta{is_edited: false} = meta} = content) do

lib/groupher_server/cms/delegates/article_community.ex

@@ -10,16 +10,9 @@ defmodule GroupherServer.CMS.Delegate.CommunityCURD do
 
   alias Helper.ORM
   alias Helper.QueryBuilder
-  alias GroupherServer.{Accounts, Repo}
+  alias GroupherServer.{Accounts, CMS}
 
-  alias GroupherServer.CMS.{
-    Category,
-    Community,
-    CommunityEditor,
-    CommunitySubscriber,
-    Tag,
-    Thread
-  }
+  alias CMS.{ArticleTag, Category, Community, CommunityEditor, CommunitySubscriber, Thread}
 
   @doc """
   return paged community subscribers
@@ -55,30 +48,6 @@ defmodule GroupherServer.CMS.Delegate.CommunityCURD do
     end
   end
 
-  @doc """
-  create a Tag base on type: post / tuts ...
-  """
-  def create_tag(%Community{id: community_id}, thread, attrs, %Accounts.User{id: user_id}) do
-    with {:ok, action} <- match_action(thread, :tag),
-         {:ok, author} <- ensure_author_exists(%Accounts.User{id: user_id}),
-         {:ok, _community} <- ORM.find(Community, community_id) do
-      attrs =
-        attrs
-        |> Map.merge(%{author_id: author.id, community_id: community_id})
-        |> map_atom_value(:string)
-        |> Map.merge(%{thread: thread |> to_string |> String.downcase()})
-
-      action.reactor |> ORM.create(attrs)
-    end
-  end
-
-  def update_tag(%{id: _id} = attrs) do
-    ~m(id title color)a = attrs |> map_atom_value(:string)
-
-    Tag
-    |> ORM.find_update(~m(id title color)a)
-  end
-
   def create_category(attrs, %Accounts.User{id: user_id}) do
     with {:ok, author} <- ensure_author_exists(%Accounts.User{id: user_id}) do
       attrs = attrs |> Map.merge(%{author_id: author.id})
@@ -128,10 +97,10 @@ defmodule GroupherServer.CMS.Delegate.CommunityCURD do
   end
 
   @doc "count the total tags in community"
-  def count(%Community{id: id}, :tags) do
+  def count(%Community{id: id}, :article_tags) do
     with {:ok, community} <- ORM.find(Community, id) do
       result =
-        Tag
+        ArticleTag
         |> where([t], t.community_id == ^community.id)
         |> ORM.paginater(page: 1, size: 1)
 

lib/groupher_server/cms/delegates/community_curd.ex

@@ -17,7 +17,6 @@ defmodule GroupherServer.CMS.Helper.Matcher do
     # commtnes reaction
     PostCommentLike,
     #
-    Tag,
     Community
   }
 
@@ -27,13 +26,6 @@ defmodule GroupherServer.CMS.Helper.Matcher do
   def match_action(:post, :self),
     do: {:ok, %{target: Post, reactor: Post, preload: :author}}
 
-  def match_action(:post, :tag), do: {:ok, %{target: Post, reactor: Tag}}
-  # NOTE: the tech, radar, share, city thread also use common tag
-  def match_action(:radar, :tag), do: {:ok, %{target: Post, reactor: Tag}}
-  def match_action(:share, :tag), do: {:ok, %{target: Post, reactor: Tag}}
-  def match_action(:city, :tag), do: {:ok, %{target: Post, reactor: Tag}}
-  def match_action(:tech, :tag), do: {:ok, %{target: Post, reactor: Tag}}
-
   def match_action(:post, :community),
     do: {:ok, %{target: Post, reactor: Community}}
 
@@ -52,8 +44,6 @@ defmodule GroupherServer.CMS.Helper.Matcher do
   def match_action(:job, :community),
     do: {:ok, %{target: Job, reactor: Community}}
 
-  def match_action(:job, :tag), do: {:ok, %{target: Job, reactor: Tag}}
-
   #########################################
   ## repos ...
   #########################################
@@ -63,8 +53,6 @@ defmodule GroupherServer.CMS.Helper.Matcher do
   def match_action(:repo, :community),
     do: {:ok, %{target: Repo, reactor: Community}}
 
-  def match_action(:repo, :tag), do: {:ok, %{target: Repo, reactor: Tag}}
-
   # dynamic where query match
   def dynamic_where(thread, id) do
     case thread do

lib/groupher_server/cms/helper/matcher.ex

@@ -9,7 +9,7 @@ defmodule GroupherServer.CMS.Job do
   import GroupherServer.CMS.Helper.Macros
 
   alias GroupherServer.CMS
-  alias CMS.{Embeds, Tag}
+  alias CMS.Embeds
   alias Helper.HTML
 
   @timestamps_opts [type: :utc_datetime_usec]
@@ -40,16 +40,6 @@ defmodule GroupherServer.CMS.Job do
     field(:digest, :string)
     field(:length, :integer)
 
-    many_to_many(
-      :tags,
-      Tag,
-      join_through: "jobs_tags",
-      join_keys: [job_id: :id, tag_id: :id],
-      # :delete_all will only remove data from the join source
-      on_delete: :delete_all,
-      on_replace: :delete
-    )
-
     article_tags_field(:job)
     article_community_field(:job)
     general_article_fields()

lib/groupher_server/cms/job.ex

@@ -9,7 +9,7 @@ defmodule GroupherServer.CMS.Post do
   import GroupherServer.CMS.Helper.Macros
 
   alias GroupherServer.CMS
-  alias CMS.{Embeds, PostComment, Tag}
+  alias CMS.{Embeds, PostComment}
 
   alias Helper.HTML
 
@@ -32,18 +32,6 @@ defmodule GroupherServer.CMS.Post do
     # TODO: remove after legacy data migrated
     has_many(:comments, {"posts_comments", PostComment})
 
-    # The keys are inflected from the schema names!
-    # see https://hexdocs.pm/ecto/Ecto.Schema.html
-    many_to_many(
-      :tags,
-      Tag,
-      join_through: "posts_tags",
-      join_keys: [post_id: :id, tag_id: :id],
-      # :delete_all will only remove data from the join source
-      on_delete: :delete_all,
-      on_replace: :delete
-    )
-
     article_tags_field(:post)
     article_community_field(:post)
     general_article_fields()

lib/groupher_server/cms/post.ex

@@ -9,7 +9,7 @@ defmodule GroupherServer.CMS.Repo do
   import GroupherServer.CMS.Helper.Macros
 
   alias GroupherServer.CMS
-  alias CMS.{Embeds, RepoContributor, RepoLang, Tag}
+  alias CMS.{Embeds, RepoContributor, RepoLang}
 
   alias Helper.HTML
 
@@ -41,15 +41,6 @@ defmodule GroupherServer.CMS.Repo do
     embeds_many(:contributors, RepoContributor, on_replace: :delete)
     field(:last_sync, :utc_datetime)
 
-    many_to_many(
-      :tags,
-      Tag,
-      join_through: "repos_tags",
-      join_keys: [repo_id: :id, tag_id: :id],
-      on_delete: :delete_all,
-      on_replace: :delete
-    )
-
     article_tags_field(:repo)
     article_community_field(:repo)
     general_article_fields()

lib/groupher_server/cms/repo.ex

@@ -18,11 +18,11 @@ defmodule GroupherServer.Statistics.Delegate.Status do
     {:ok, %{total_count: repos_count}} = find_total_count(CMS.Repo)
 
     {:ok, %{total_count: threads_count}} = find_total_count(CMS.Thread)
-    {:ok, %{total_count: tags_count}} = find_total_count(CMS.Tag)
+    {:ok, %{total_count: article_tags_count}} = find_total_count(CMS.ArticleTag)
     {:ok, %{total_count: categories_count}} = find_total_count(CMS.Category)
 
     {:ok,
-     ~m(communities_count posts_count jobs_count repos_count threads_count tags_count categories_count)a}
+     ~m(communities_count posts_count jobs_count repos_count threads_count article_tags_count categories_count)a}
   end
 
   defp find_total_count(queryable), do: ORM.find_all(queryable, @count_filter)

lib/groupher_server/cms/tag.ex

@@ -388,7 +388,7 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     CMS.count(%Community{id: root.id}, :threads)
   end
 
-  def tags_count(root, _, _) do
-    CMS.count(%Community{id: root.id}, :tags)
+  def article_tags_count(root, _, _) do
+    CMS.count(%Community{id: root.id}, :article_tags)
   end
 end

lib/groupher_server/statistics/delegates/status.ex

@@ -39,7 +39,7 @@ defmodule GroupherServerWeb.Schema.Helper.Fields do
     quote do
       field(:when, :when_enum)
       field(:length, :length_enum)
-      field(:tag, :string, default_value: :all)
+      field(:article_tag, :string)
       field(:community, :string)
     end
   end

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -9,7 +9,6 @@ defmodule GroupherServerWeb.Schema.Account.Misc do
     pagination_args()
     # field(:when, :when_enum)
     # field(:sort, :sort_enum)
-    # field(:tag, :string, default_value: :all)
     # field(:community, :string)
   end
 

lib/groupher_server_web/schema/Helper/fields.ex

@@ -174,7 +174,7 @@ defmodule GroupherServerWeb.Schema.CMS.Misc do
     field(:first, :integer)
 
     @desc "Matching a tag"
-    field(:tag, :string, default_value: :all)
+    field(:article_tag, :string)
     # field(:sort, :sort_input)
     field(:when, :when_enum)
     field(:sort, :sort_enum)