refactor(article-tags): add article_tag & community filter test

Author: mydearxym

lib/helper/query_builder.ex

@@ -174,7 +174,6 @@ defmodule Helper.QueryBuilder do
       {_, :all}, queryable ->
         queryable
 
-      # TODO: use raw instead title
       {:article_tag, tag_name}, queryable ->
         from(
           q in queryable,
@@ -189,17 +188,17 @@ defmodule Helper.QueryBuilder do
           where: t.raw == ^catetory_raw
         )
 
+      {:thread, thread}, queryable ->
+        thread = thread |> to_string |> String.upcase()
+        from(q in queryable, where: q.thread == ^thread)
+
       {:community_id, community_id}, queryable ->
         from(
           q in queryable,
           join: t in assoc(q, :community),
           where: t.id == ^community_id
         )
 
-      {:thread, thread}, queryable ->
-        thread = thread |> to_string |> String.upcase()
-        from(q in queryable, where: q.thread == ^thread)
-
       {:community, community_raw}, queryable ->
         from(
           q in queryable,

test/groupher_server/cms/article_tags/post_tag_test.exs

@@ -18,7 +18,6 @@ defmodule GroupherServer.Test.CMS.ArticleTag.PostTag do
   end
 
   describe "[post tag CURD]" do
-    @tag :wip2
     test "create article tag with valid data", ~m(community article_tag_attrs user)a do
       {:ok, article_tag} = CMS.create_article_tag(community, :post, article_tag_attrs, user)
       assert article_tag.title == article_tag_attrs.title

test/groupher_server_web/mutation/cms/article_tags/curd_test.exs

@@ -38,7 +38,7 @@ defmodule GroupherServer.Test.Mutation.CMS.ArticleArticleTags.CURD do
       }
     }
     """
-    @tag :wip2
+
     test "create tag with valid attrs, has default POST thread and default posts",
          ~m(community)a do
       variables = %{

test/groupher_server_web/query/accounts/colleced_articles_test.exs

@@ -49,7 +49,6 @@ defmodule GroupherServer.Test.Query.Accounts.CollectedArticles do
     assert results2 |> is_valid_pagination?()
   end
 
-  @tag :wip2
   test "other user can get other user's paged collect folders filter by thread",
        ~m(guest_conn)a do
     {:ok, user} = db_insert(:user)

test/groupher_server_web/query/cms/paged_articles/paged_jobs_test.exs

@@ -44,6 +44,10 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedJobs do
       pagedJobs(filter: $filter) {
         entries {
           id
+          communities {
+            id
+            raw
+          }
           articleTags {
             id
           }
@@ -65,6 +69,41 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedJobs do
       assert results["entries"] |> List.first() |> Map.get("articleTags") |> is_list
     end
 
+    @tag :wip2
+    test "support article_tag filter", ~m(guest_conn user)a do
+      {:ok, community} = db_insert(:community)
+      job_attrs = mock_attrs(:job, %{community_id: community.id})
+      {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
+
+      article_tag_attrs = mock_attrs(:article_tag)
+      {:ok, article_tag} = CMS.create_article_tag(community, :job, article_tag_attrs, user)
+      {:ok, _} = CMS.set_article_tag(:job, job.id, article_tag.id)
+
+      variables = %{filter: %{page: 1, size: 10, article_tag: article_tag.title}}
+      results = guest_conn |> query_result(@query, variables, "pagedJobs")
+
+      job = results["entries"] |> List.first()
+      assert results["totalCount"] == 1
+      assert exist_in?(article_tag, job["articleTags"], :string_key)
+    end
+
+    @tag :wip2
+    test "support community filter", ~m(guest_conn user)a do
+      {:ok, community} = db_insert(:community)
+
+      job_attrs = mock_attrs(:job, %{community_id: community.id})
+      {:ok, _job} = CMS.create_article(community, :job, job_attrs, user)
+      job_attrs2 = mock_attrs(:job, %{community_id: community.id})
+      {:ok, _job} = CMS.create_article(community, :job, job_attrs2, user)
+
+      variables = %{filter: %{page: 1, size: 10, community: community.raw}}
+      results = guest_conn |> query_result(@query, variables, "pagedJobs")
+
+      job = results["entries"] |> List.first()
+      assert results["totalCount"] == 2
+      assert exist_in?(%{id: to_string(community.id)}, job["communities"], :string_key)
+    end
+
     test "request large size fails", ~m(guest_conn)a do
       variables = %{filter: %{page: 1, size: 200}}
       assert guest_conn |> query_get_error?(@query, variables, ecode(:pagination))

test/groupher_server_web/query/cms/paged_articles/paged_posts_test.exs

@@ -46,6 +46,7 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedPosts do
         entries {
           id
           communities {
+            id
             raw
           }
           articleTags {
@@ -59,7 +60,6 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedPosts do
       }
     }
     """
-
     test "should get pagination info", ~m(guest_conn)a do
       variables = %{filter: %{page: 1, size: 10}}
       results = guest_conn |> query_result(@query, variables, "pagedPosts")
@@ -70,6 +70,39 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedPosts do
       assert results["entries"] |> List.first() |> Map.get("articleTags") |> is_list
     end
 
+    test "support article_tag filter", ~m(guest_conn user)a do
+      {:ok, community} = db_insert(:community)
+      post_attrs = mock_attrs(:post, %{community_id: community.id})
+      {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
+
+      article_tag_attrs = mock_attrs(:article_tag)
+      {:ok, article_tag} = CMS.create_article_tag(community, :post, article_tag_attrs, user)
+      {:ok, _} = CMS.set_article_tag(:post, post.id, article_tag.id)
+
+      variables = %{filter: %{page: 1, size: 10, article_tag: article_tag.title}}
+      results = guest_conn |> query_result(@query, variables, "pagedPosts")
+
+      post = results["entries"] |> List.first()
+      assert results["totalCount"] == 1
+      assert exist_in?(article_tag, post["articleTags"], :string_key)
+    end
+
+    test "support community filter", ~m(guest_conn user)a do
+      {:ok, community} = db_insert(:community)
+
+      post_attrs = mock_attrs(:post, %{community_id: community.id})
+      {:ok, _post} = CMS.create_article(community, :post, post_attrs, user)
+      post_attrs2 = mock_attrs(:post, %{community_id: community.id})
+      {:ok, _post} = CMS.create_article(community, :post, post_attrs2, user)
+
+      variables = %{filter: %{page: 1, size: 10, community: community.raw}}
+      results = guest_conn |> query_result(@query, variables, "pagedPosts")
+
+      post = results["entries"] |> List.first()
+      assert results["totalCount"] == 2
+      assert exist_in?(%{id: to_string(community.id)}, post["communities"], :string_key)
+    end
+
     test "request large size fails", ~m(guest_conn)a do
       variables = %{filter: %{page: 1, size: 200}}
       assert guest_conn |> query_get_error?(@query, variables, ecode(:pagination))

test/groupher_server_web/query/cms/paged_articles/paged_repos_test.exs

@@ -40,6 +40,10 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedRepos do
       pagedRepos(filter: $filter) {
         entries {
           id
+          communities {
+            id
+            raw
+          }
           articleTags {
             id
           }
@@ -62,6 +66,41 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedRepos do
       assert results["entries"] |> List.first() |> Map.get("articleTags") |> is_list
     end
 
+    @tag :wip2
+    test "support article_tag filter", ~m(guest_conn user)a do
+      {:ok, community} = db_insert(:community)
+      repo_attrs = mock_attrs(:repo, %{community_id: community.id})
+      {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
+
+      article_tag_attrs = mock_attrs(:article_tag)
+      {:ok, article_tag} = CMS.create_article_tag(community, :repo, article_tag_attrs, user)
+      {:ok, _} = CMS.set_article_tag(:repo, repo.id, article_tag.id)
+
+      variables = %{filter: %{page: 1, size: 10, article_tag: article_tag.title}}
+      results = guest_conn |> query_result(@query, variables, "pagedRepos")
+
+      repo = results["entries"] |> List.first()
+      assert results["totalCount"] == 1
+      assert exist_in?(article_tag, repo["articleTags"], :string_key)
+    end
+
+    @tag :wip2
+    test "support community filter", ~m(guest_conn user)a do
+      {:ok, community} = db_insert(:community)
+
+      repo_attrs = mock_attrs(:repo, %{community_id: community.id})
+      {:ok, _repo} = CMS.create_article(community, :repo, repo_attrs, user)
+      repo_attrs2 = mock_attrs(:repo, %{community_id: community.id})
+      {:ok, _repo} = CMS.create_article(community, :repo, repo_attrs2, user)
+
+      variables = %{filter: %{page: 1, size: 10, community: community.raw}}
+      results = guest_conn |> query_result(@query, variables, "pagedRepos")
+
+      repo = results["entries"] |> List.first()
+      assert results["totalCount"] == 2
+      assert exist_in?(%{id: to_string(community.id)}, repo["communities"], :string_key)
+    end
+
     test "request large size fails", ~m(guest_conn)a do
       variables = %{filter: %{page: 1, size: 200}}
       assert guest_conn |> query_get_error?(@query, variables, ecode(:pagination))