refactor(article-tags): fix tests

Author: mydearxym

lib/groupher_server/cms/article_tag.ex

@@ -3,6 +3,8 @@ defmodule GroupherServer.CMS.ArticleTag do
   alias __MODULE__
 
   use Ecto.Schema
+  use Accessible
+
   import Ecto.Changeset
 
   alias GroupherServer.CMS

lib/groupher_server/cms/helper/loader.ex

@@ -12,6 +12,7 @@ defmodule GroupherServer.CMS.Helper.Loader do
     CommunityEditor,
     CommunitySubscriber,
     CommunityThread,
+    ArticleTag,
     # POST
     Post,
     PostComment,

lib/groupher_server_web/schema/cms/cms_types.ex

@@ -64,7 +64,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     # NOTE: only meaningful in paged-xxx queries
     field(:is_pinned, :boolean)
     field(:mark_delete, :boolean)
-    field(:article_tags, list_of(:article_tag), resolve: dataloader(CMS, :article_tag))
+    field(:article_tags, list_of(:article_tag), resolve: dataloader(CMS, :article_tags))
 
     field(:author, :user, resolve: dataloader(CMS, :author))
     field(:original_community, :community, resolve: dataloader(CMS, :original_community))
@@ -122,7 +122,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:mark_delete, :boolean)
 
     field(:author, :user, resolve: dataloader(CMS, :author))
-    field(:article_tags, list_of(:article_tag), resolve: dataloader(CMS, :article_tag))
+    field(:article_tags, list_of(:article_tag), resolve: dataloader(CMS, :article_tags))
     field(:original_community, :community, resolve: dataloader(CMS, :original_community))
     field(:communities, list_of(:community), resolve: dataloader(CMS, :communities))
 
@@ -174,7 +174,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
 
     field(:last_sync, :datetime)
 
-    field(:article_tags, list_of(:article_tag), resolve: dataloader(CMS, :article_tag))
+    field(:article_tags, list_of(:article_tag), resolve: dataloader(CMS, :article_tags))
     field(:original_community, :community, resolve: dataloader(CMS, :original_community))
     field(:communities, list_of(:community), resolve: dataloader(CMS, :communities))
 

test/groupher_server_web/mutation/cms/articles/job_test.exs

@@ -142,7 +142,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Job do
         title
         body
         salary
-        tags {
+        articleTags {
           id
         }
       }
@@ -191,7 +191,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Job do
         body: "updated body #{unique_num}"
       }
 
-      updated = rule_conn |> mutation_result(@query, variables, "updateJob")
+      updated = rule_conn |> mutation_result(@query, variables, "updateJob", :debug)
 
       assert updated["id"] == to_string(job.id)
     end

test/groupher_server_web/mutation/cms/articles/post_test.exs

@@ -177,6 +177,9 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
           id
           nickname
         }
+        articleTags {
+          id
+        }
       }
     }
     """
@@ -192,6 +195,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
       assert guest_conn |> mutation_get_error?(@query, variables, ecode(:account_login))
     end
 
+    @tag :wip2
     test "post can be update by owner", ~m(owner_conn post)a do
       unique_num = System.unique_integer([:positive, :monotonic])
 

test/groupher_server_web/mutation/statistics/statistics_test.exs

@@ -39,7 +39,6 @@ defmodule GroupherServer.Test.Mutation.Statistics do
       }
     }
     """
-    @tag :wip2
     test "user should have contribute list after create a post", ~m(user_conn user community)a do
       post_attr = mock_attrs(:post)
       variables = post_attr |> Map.merge(%{communityId: community.id})

test/groupher_server_web/query/cms/paged_articles/paged_jobs_test.exs

@@ -44,6 +44,9 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedJobs do
       pagedJobs(filter: $filter) {
         entries {
           id
+          articleTags {
+            id
+          }
         }
         totalPages
         totalCount
@@ -52,13 +55,15 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedJobs do
       }
     }
     """
+    @tag :wip2
     test "should get pagination info", ~m(guest_conn)a do
       variables = %{filter: %{page: 1, size: 10}}
       results = guest_conn |> query_result(@query, variables, "pagedJobs")
 
       assert results |> is_valid_pagination?
       assert results["pageSize"] == 10
       assert results["totalCount"] == @total_count
+      assert results["entries"] |> List.first() |> Map.get("articleTags") |> is_list
     end
 
     test "request large size fails", ~m(guest_conn)a do

test/groupher_server_web/query/cms/paged_articles/paged_posts_test.exs

@@ -48,6 +48,9 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedPosts do
           communities {
             raw
           }
+          articleTags {
+            id
+          }
         }
         totalPages
         totalCount
@@ -56,13 +59,15 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedPosts do
       }
     }
     """
+    @tag :wip2
     test "should get pagination info", ~m(guest_conn)a do
       variables = %{filter: %{page: 1, size: 10}}
       results = guest_conn |> query_result(@query, variables, "pagedPosts")
 
       assert results |> is_valid_pagination?
       assert results["pageSize"] == 10
       assert results["totalCount"] == @total_count
+      assert results["entries"] |> List.first() |> Map.get("articleTags") |> is_list
     end
 
     test "request large size fails", ~m(guest_conn)a do

test/groupher_server_web/query/cms/paged_articles/paged_repos_test.exs

@@ -40,6 +40,9 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedRepos do
       pagedRepos(filter: $filter) {
         entries {
           id
+          articleTags {
+            id
+          }
         }
         totalPages
         totalCount
@@ -48,13 +51,15 @@ defmodule GroupherServer.Test.Query.PagedArticles.PagedRepos do
       }
     }
     """
+    @tag :wip2
     test "should get pagination info", ~m(guest_conn)a do
       variables = %{filter: %{page: 1, size: 10}}
       results = guest_conn |> query_result(@query, variables, "pagedRepos")
 
       assert results |> is_valid_pagination?
       assert results["pageSize"] == 10
       assert results["totalCount"] == @total_count
+      assert results["entries"] |> List.first() |> Map.get("articleTags") |> is_list
     end
 
     test "request large size fails", ~m(guest_conn)a do