test(article): body parse & test adjust

Author: mydearxym

lib/groupher_server/cms/delegates/article_curd.ex

@@ -405,12 +405,14 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
     end
   end
 
-  defp do_update_article(article, attrs) do
+  defp do_update_article(article, %{body: _} = attrs) do
     with {:ok, attrs} <- add_rich_text_attrs(attrs) do
       ORM.update(article, attrs)
     end
   end
 
+  defp do_update_article(article, attrs), do: ORM.update(article, attrs)
+
   # is update or create article with body field, parsed and extand it into attrs
   defp add_rich_text_attrs(%{body: body} = attrs) when not is_nil(body) do
     with {:ok, parsed} <- Converter.Article.parse_body(body),
@@ -457,7 +459,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   defp result({:ok, %{update_edit_status: result}}), do: {:ok, result}
   defp result({:ok, %{update_article: result}}), do: {:ok, result}
   defp result({:ok, %{set_viewer_has_states: result}}), do: result |> done()
-  defp result({:ok, %{update_article_meta: result}}), do: {:ok, result}
 
   defp result({:error, :create_article, _result, _steps}) do
     {:error, [message: "create article", code: ecode(:create_fails)]}

test/groupher_server/cms/articles/post_test.exs

@@ -23,7 +23,6 @@ defmodule GroupherServer.Test.CMS.Articles.Post do
   end
 
   describe "[cms post curd]" do
-    @tag :wip
     test "can create post with valid attrs", ~m(user community post_attrs)a do
       assert {:error, _} = ORM.find_by(Author, user_id: user.id)
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -173,6 +172,7 @@ defmodule GroupherServer.Test.CMS.Articles.Post do
       assert post.is_question
     end
 
+    @tag :wip
     test "can update post with question", ~m(user community post_attrs)a do
       post_attrs = Map.merge(post_attrs, %{is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)

test/groupher_server_web/mutation/cms/articles/post_test.exs

@@ -200,7 +200,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
       }
     }
     """
-    @tag :wip
+
     test "update a post without login user fails", ~m(guest_conn post)a do
       unique_num = System.unique_integer([:positive, :monotonic])
 
@@ -213,7 +213,6 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
       assert guest_conn |> mutation_get_error?(@query, variables, ecode(:account_login))
     end
 
-    @tag :wip
     test "post can be update by owner", ~m(owner_conn post)a do
       unique_num = System.unique_integer([:positive, :monotonic])
 

test/groupher_server_web/query/cms/abuse_reports/repo_report_test.exs

@@ -91,7 +91,6 @@ defmodule GroupherServer.Test.Query.AbuseReports.RepoReport do
       assert results["totalCount"] == 1
     end
 
-    @tag :wip
     test "support article_comment", ~m(guest_conn repo user)a do
       {:ok, comment} = CMS.create_article_comment(:repo, repo.id, mock_comment(), user)
       {:ok, _} = CMS.report_article_comment(comment.id, mock_comment(), "attr", user)