refactor(article-tags): add group field support

Author: mydearxym

lib/groupher_server/cms/article_tag.ex

@@ -11,13 +11,15 @@ defmodule GroupherServer.CMS.ArticleTag do
   alias CMS.{Author, Community}
 
   @required_fields ~w(thread title color author_id community_id)a
-  @updatable_fields ~w(thread title color community_id)a
+  @updatable_fields ~w(thread title color community_id group)a
 
   @type t :: %ArticleTag{}
   schema "article_tags" do
     field(:title, :string)
     field(:color, :string)
     field(:thread, :string)
+    field(:group, :string)
+
     belongs_to(:community, Community)
     belongs_to(:author, Author)
 
@@ -26,7 +28,7 @@ defmodule GroupherServer.CMS.ArticleTag do
 
   def changeset(%ArticleTag{} = tag, attrs) do
     tag
-    |> cast(attrs, @required_fields)
+    |> cast(attrs, @required_fields ++ @updatable_fields)
     |> validate_required(@required_fields)
     |> foreign_key_constraint(:user_id)
     |> foreign_key_constraint(:community_id)

lib/groupher_server_web/schema/cms/cms_types.ex

@@ -337,6 +337,8 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:title, :string)
     field(:color, :string)
     field(:thread, :string)
+    field(:group, :string)
+
     field(:author, :user, resolve: dataloader(CMS, :author))
     field(:community, :community, resolve: dataloader(CMS, :community))
 

lib/groupher_server_web/schema/cms/mutations/community.ex

@@ -131,6 +131,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Community do
       arg(:title, non_null(:string))
       arg(:color, non_null(:rainbow_color))
       arg(:community_id, non_null(:id))
+      arg(:group, :string)
       arg(:thread, :thread, default_value: :post)
 
       middleware(M.Authorize, :login)
@@ -146,6 +147,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Community do
       arg(:community_id, non_null(:id))
       arg(:title, :string)
       arg(:color, :rainbow_color)
+      arg(:group, :string)
       arg(:thread, :thread, default_value: :post)
 
       middleware(M.Authorize, :login)

priv/repo/migrations/20210519055419_add_group_to_article_tag.exs

@@ -0,0 +1,9 @@
+defmodule GroupherServer.Repo.Migrations.AddGroupToArticleTag do
+  use Ecto.Migration
+
+  def change do
+    alter table(:article_tags) do
+      add(:group, :string)
+    end
+  end
+end

test/groupher_server/cms/article_tags/job_tag_test.exs

@@ -21,6 +21,7 @@ defmodule GroupherServer.Test.CMS.ArticleTag.JobTag do
     test "create article tag with valid data", ~m(community article_tag_attrs user)a do
       {:ok, article_tag} = CMS.create_article_tag(community, :job, article_tag_attrs, user)
       assert article_tag.title == article_tag_attrs.title
+      assert article_tag.group == article_tag_attrs.group
     end
 
     test "can update an article tag", ~m(community article_tag_attrs user)a do

test/groupher_server/cms/article_tags/post_tag_test.exs

@@ -18,9 +18,11 @@ defmodule GroupherServer.Test.CMS.ArticleTag.PostTag do
   end
 
   describe "[post tag CURD]" do
+    @tag :wip2
     test "create article tag with valid data", ~m(community article_tag_attrs user)a do
       {:ok, article_tag} = CMS.create_article_tag(community, :post, article_tag_attrs, user)
       assert article_tag.title == article_tag_attrs.title
+      assert article_tag.group == article_tag_attrs.group
     end
 
     test "can update an article tag", ~m(community article_tag_attrs user)a do

test/groupher_server/cms/article_tags/repo_tag_test.exs

@@ -21,6 +21,7 @@ defmodule GroupherServer.Test.CMS.ArticleTag.RepoTag do
     test "create article tag with valid data", ~m(community article_tag_attrs user)a do
       {:ok, article_tag} = CMS.create_article_tag(community, :repo, article_tag_attrs, user)
       assert article_tag.title == article_tag_attrs.title
+      assert article_tag.group == article_tag_attrs.group
     end
 
     test "can update an article tag", ~m(community article_tag_attrs user)a do

test/groupher_server_web/mutation/cms/article_tags/curd_test.exs

@@ -23,8 +23,8 @@ defmodule GroupherServer.Test.Mutation.CMS.ArticleArticleTags.CURD do
 
   describe "[mutation cms tag]" do
     @create_tag_query """
-    mutation($thread: Thread!, $title: String!, $color: RainbowColor!, $communityId: ID!) {
-      createArticleTag(thread: $thread, title: $title, color: $color, communityId: $communityId) {
+    mutation($thread: Thread!, $title: String!, $color: RainbowColor!, $group: String, $communityId: ID!) {
+      createArticleTag(thread: $thread, title: $title, color: $color, group: $group, communityId: $communityId) {
         id
         title
         color
@@ -37,14 +37,15 @@ defmodule GroupherServer.Test.Mutation.CMS.ArticleArticleTags.CURD do
       }
     }
     """
-
+    @tag :wip2
     test "create tag with valid attrs, has default POST thread and default posts",
          ~m(community)a do
       variables = %{
         title: "tag title",
         communityId: community.id,
         thread: "POST",
-        color: "GREEN"
+        color: "GREEN",
+        group: "awesome"
       }
 
       passport_rules = %{community.title => %{"post.article_tag.create" => true}}
@@ -58,6 +59,7 @@ defmodule GroupherServer.Test.Mutation.CMS.ArticleArticleTags.CURD do
 
       assert created["id"] == to_string(found.id)
       assert found.thread == "POST"
+      assert found.group == "awesome"
       assert belong_community["id"] == to_string(community.id)
     end
 

test/support/factory.ex

@@ -197,6 +197,7 @@ defmodule GroupherServer.Support.Factory do
       title: "#{Faker.Pizza.cheese()} #{unique_num}",
       thread: "POST",
       color: "YELLOW",
+      group: "cool",
       # community: Faker.Pizza.topping(),
       community: mock(:community),
       author: mock(:author)