fix(user): login args in test

Author: mydearxym

test/groupher_server/accounts/fans_test.exs

@@ -22,7 +22,6 @@ defmodule GroupherServer.Test.Accounts.Fans do
       assert found |> Map.get(:followers) |> length == 1
     end
 
-    @tag :wip2
     test "follow user should update follow meta info", ~m(user)a do
       {:ok, user2} = db_insert(:user)
 
@@ -76,7 +75,6 @@ defmodule GroupherServer.Test.Accounts.Fans do
       assert found |> Map.get(:followers) |> length == 0
     end
 
-    @tag :wip2
     test "undo follow user should update follow meta info", ~m(user)a do
       {:ok, user2} = db_insert(:user)
 

test/groupher_server_web/mutation/accounts/fans_test.exs

@@ -24,7 +24,6 @@ defmodule GroupherServer.Test.Mutation.Accounts.Fans do
       }
     }
     """
-    @tag :wip2
     test "login user can follow other user", ~m(user_conn)a do
       {:ok, user2} = db_insert(:user)
 
@@ -35,7 +34,6 @@ defmodule GroupherServer.Test.Mutation.Accounts.Fans do
       assert followed["viewerHasFollowed"] == false
     end
 
-    @tag :wip2
     test "login user follow other user twice fails", ~m(user_conn)a do
       {:ok, user2} = db_insert(:user)
 
@@ -46,20 +44,17 @@ defmodule GroupherServer.Test.Mutation.Accounts.Fans do
       assert user_conn |> mutation_get_error?(@query, variables, ecode(:already_did))
     end
 
-    @tag :wip2
     test "login user follow self fails", ~m(user_conn user)a do
       variables = %{login: user.login}
       assert user_conn |> mutation_get_error?(@query, variables, ecode(:self_conflict))
     end
 
-    @tag :wip2
     test "login user follow no-exsit cuser fails", ~m(user_conn)a do
       variables = %{login: non_exsit_login()}
 
       assert user_conn |> mutation_get_error?(@query, variables, ecode(:not_exsit))
     end
 
-    @tag :wip2
     test "unauth user follow other user fails", ~m(guest_conn)a do
       {:ok, user2} = db_insert(:user)
       variables = %{login: user2.login}
@@ -73,7 +68,7 @@ defmodule GroupherServer.Test.Mutation.Accounts.Fans do
       }
     }
     """
-    @tag :wip2
+
     test "login user can undo follow other user", ~m(user_conn user)a do
       {:ok, user2} = db_insert(:user)
       {:ok, _followeer} = user |> Accounts.follow(user2)

test/groupher_server_web/query/accounts/account_test.exs

@@ -160,7 +160,6 @@ defmodule GroupherServer.Test.Query.Account.Basic do
       assert results |> is_valid_pagination?()
     end
 
-    @tag :wip2
     test "login user can get paged users with follow state info", ~m(user_conn user)a do
       variables = %{filter: %{page: 1, size: 10}}
 

test/groupher_server_web/query/accounts/achievement_test.exs

@@ -84,8 +84,8 @@ defmodule GroupherServer.Test.Query.Account.Achievement do
     end
 
     @query """
-    query {
-      user {
+    query($login: String!) {
+      user(login: $login) {
         id
         editableCommunities {
           entries {

test/groupher_server_web/query/accounts/customization_test.exs

@@ -13,8 +13,8 @@ defmodule GroupherServer.Test.Query.Account.Customization do
 
   describe "[account customization]" do
     @query """
-    query {
-      user {
+    query($login: String!) {
+      user(login: $login) {
         id
         nickname
         customization {
@@ -30,8 +30,9 @@ defmodule GroupherServer.Test.Query.Account.Customization do
       }
     }
     """
+    @tag :wip2
     test "user can have default customization configs", ~m(user_conn user)a do
-      results = user_conn |> query_result(@query, %{}, "user")
+      results = user_conn |> query_result(@query, %{login: user.login}, "user", :debug)
 
       assert results["id"] == to_string(user.id)
       assert results["customization"]["theme"] == Customization.default() |> Map.get(:theme)

test/groupher_server_web/query/accounts/fans_test.exs

@@ -46,7 +46,6 @@ defmodule GroupherServer.Test.Query.Account.Fans do
       assert user3 |> exist_in?(entries, :string_key)
     end
 
-    @tag :wip2
     test "login user can get other user's paged followers", ~m(guest_conn user)a do
       {:ok, user2} = db_insert(:user)
       {:ok, _followeer} = user |> Accounts.follow(user2)
@@ -71,7 +70,7 @@ defmodule GroupherServer.Test.Query.Account.Fans do
       }
     }
     """
-    @tag :wip2
+
     test "login user can get it's own paged followings", ~m(user_conn user)a do
       variables = %{login: user.login, filter: %{page: 1, size: 20}}
 

test/groupher_server_web/query/accounts/mention_test.exs

@@ -14,8 +14,8 @@ defmodule GroupherServer.Test.Query.Accounts.Mention do
 
   describe "[accounts mailbox status]" do
     @query """
-    query {
-      user {
+    query($login: String!) {
+      user(login: $login) {
         id
         mailBox {
           hasMail
@@ -26,6 +26,7 @@ defmodule GroupherServer.Test.Query.Accounts.Mention do
       }
     }
     """
+    @tag :wip2
     test "auth user can get it's own mailbox status" do
       {:ok, [user, user2]} = db_insert_multi(:user, 2)
 
@@ -34,7 +35,7 @@ defmodule GroupherServer.Test.Query.Accounts.Mention do
 
       user_conn = simu_conn(:user, user)
 
-      variables = %{}
+      variables = %{login: user.login}
       results = user_conn |> query_result(@query, variables, "user")
       mail_Box = results["mailBox"]
 

test/groupher_server_web/query/accounts/messages_test.exs

@@ -13,8 +13,8 @@ defmodule GroupherServer.Test.Query.Accounts.Messages do
 
   describe "[account messages queries]" do
     @query """
-    query {
-      user {
+    query($login: String!) {
+      user(login: $login) {
         id
         mailBox {
           hasMail
@@ -25,11 +25,12 @@ defmodule GroupherServer.Test.Query.Accounts.Messages do
       }
     }
     """
+    @tag :wip2
     test "login user can get mail box status" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)
 
-      result = user_conn |> query_result(@query, %{}, "user")
+      result = user_conn |> query_result(@query, %{login: user.login}, "user")
       mail_box = result["mailBox"]
       assert mail_box["hasMail"] == false
       assert mail_box["totalCount"] == 0
@@ -39,7 +40,7 @@ defmodule GroupherServer.Test.Query.Accounts.Messages do
       mock_mentions_for(user, 2)
       mock_notifications_for(user, 18)
 
-      result = user_conn |> query_result(@query, %{}, "user")
+      result = user_conn |> query_result(@query, %{login: user.login}, "user")
       mail_box = result["mailBox"]
       assert mail_box["hasMail"] == true
       assert mail_box["totalCount"] == 20
@@ -54,8 +55,8 @@ defmodule GroupherServer.Test.Query.Accounts.Messages do
     end
 
     @query """
-    query($filter: MessagesFilter!) {
-      user {
+    query($login: String!, $filter: MessagesFilter!) {
+      user(login: $login) {
         id
         mentions(filter: $filter) {
           entries {
@@ -85,56 +86,59 @@ defmodule GroupherServer.Test.Query.Accounts.Messages do
       }
     }
     """
+    @tag :wip2
     test "user can get mentions send by others" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)
 
-      variables = %{filter: %{page: 1, size: 20, read: false}}
+      variables = %{login: user.login, filter: %{page: 1, size: 20, read: false}}
       result = user_conn |> query_result(@query, variables, "user")
       mentions = result["mentions"]
       assert mentions["totalCount"] == 0
 
       mock_mentions_for(user, 3)
 
-      variables = %{filter: %{page: 1, size: 20, read: false}}
+      variables = %{login: user.login, filter: %{page: 1, size: 20, read: false}}
       result = user_conn |> query_result(@query, variables, "user")
       mentions = result["mentions"]
 
       assert mentions["totalCount"] == 3
       assert mentions["entries"] |> List.first() |> Map.get("toUserId") == to_string(user.id)
     end
 
+    @tag :wip2
     test "user can get notifications send by others" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)
 
-      variables = %{filter: %{page: 1, size: 20, read: false}}
+      variables = %{login: user.login, filter: %{page: 1, size: 20, read: false}}
       result = user_conn |> query_result(@query, variables, "user")
       notifications = result["notifications"]
       assert notifications["totalCount"] == 0
 
       mock_notifications_for(user, 3)
 
-      variables = %{filter: %{page: 1, size: 20, read: false}}
+      variables = %{login: user.login, filter: %{page: 1, size: 20, read: false}}
       result = user_conn |> query_result(@query, variables, "user")
       notifications = result["notifications"]
 
       assert notifications["totalCount"] == 3
       assert notifications["entries"] |> List.first() |> Map.get("toUserId") == to_string(user.id)
     end
 
+    @tag :wip2
     test "user can get system notifications" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)
 
-      variables = %{filter: %{page: 1, size: 20, read: false}}
+      variables = %{login: user.login, filter: %{page: 1, size: 20, read: false}}
       result = user_conn |> query_result(@query, variables, "user")
       notifications = result["sysNotifications"]
       assert notifications["totalCount"] == 0
 
       mock_sys_notification(5)
 
-      variables = %{filter: %{page: 1, size: 20, read: false}}
+      variables = %{login: user.login, filter: %{page: 1, size: 20, read: false}}
       result = user_conn |> query_result(@query, variables, "user")
       notifications = result["sysNotifications"]