Add comments, Remove unnecessary code

Fix build issues

Fix build issue

Remove support for wasm build

Remove support for wasm build

Remove support for wasm build

Fix build issues

Update contributers license

Update to snake case

Fix build issues

Fix build issues

Fix build issues

Fix build issues

Fix build issues

Fix build issues

Fix build issues

Author: tharun571

.github/workflows/main.yml

@@ -74,12 +74,6 @@ jobs:
         run: |
           micromamba shell hook -s cmd.exe -p C:\Users\runneradmin\micromamba-root
 
-      - name: activate environment
-        if: ${{ runner.os != 'windows' }}
-        shell: bash -l {0}
-        run: |
-          micromamba activate xeus-cpp
-
       - name: install cxx compiler
         if: ${{ runner.os != 'windows' }}
         shell: bash -l {0}
@@ -124,17 +118,13 @@ jobs:
           cd build
           make install -j ${{ env.ncpus }}
 
-      # - name: Setup tmate session
-      #   if: ${{ runner.os != 'windows' }}
-      #   uses: mxschmitt/action-tmate@v3
-
       - name: Test xeus-cpp C++ Unix Systems
         if: ${{ runner.os != 'windows' }}
         shell: bash -l {0}
         run: |
           cd build/test
           ./test_xeus_cpp
-        timeout-minutes: 30
+        timeout-minutes: 4
 
       - name: Test xeus-cpp C++ Windows Systems
         if: ${{ runner.os == 'windows' }}

CMakeLists.txt

@@ -203,10 +203,15 @@ set(XEUS_CPP_SRC
     src/xoptions.cpp
     src/xparser.cpp
     src/xutils.cpp
-    src/xmagics/xassist.hpp
-    src/xmagics/xassist.cpp
 )
 
+if(NOT EMSCRIPTEN)
+    list(APPEND XEUS_CPP_SRC
+        src/xmagics/xassist.hpp
+        src/xmagics/xassist.cpp
+    )
+endif()
+
 if(EMSCRIPTEN)
     list(APPEND XEUS_CPP_SRC src/xinterpreter_wasm.cpp)
 endif()
@@ -312,7 +317,8 @@ macro(xeus_cpp_create_target target_name linkage output_name)
         set(XEUS_CPP_XEUS_TARGET xeus-static)
     endif ()
 
-    if(WIN32)
+    #This is a workaround for the issue with the libcurl target on Windows specifically for xassist
+    if (WIN32)
         # Set the MSVC runtime library
         set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
 
@@ -337,8 +343,11 @@ macro(xeus_cpp_create_target target_name linkage output_name)
         if (MSVC)
             target_compile_options(${target_name} PRIVATE "/MD$<$<CONFIG:Debug>:d>")
         endif()
-    else()
+    elseif (NOT EMSCRIPTEN)
+        # Curl initialised specifically for xassist
         target_link_libraries(${target_name} PUBLIC ${XEUS_CPP_XEUS_TARGET} clangCppInterOp pugixml argparse::argparse curl)
+    else ()
+        target_link_libraries(${target_name} PUBLIC ${XEUS_CPP_XEUS_TARGET} clangCppInterOp pugixml argparse::argparse)
     endif()
 
     if (WIN32 OR CYGWIN)

environment-wasm-build.yml

@@ -4,5 +4,4 @@ channels:
 dependencies:
   - cmake
   - emsdk >=3.1.11
-  - empack >=2.0.1
-  - curl
+  - empack >=2.0.1

src/xinterpreter.cpp

@@ -28,7 +28,9 @@
 #include "xinput.hpp"
 #include "xinspect.hpp"
 #include "xmagics/os.hpp"
+#ifndef EMSCRIPTEN
 #include "xmagics/xassist.hpp"
+#endif
 #include "xparser.hpp"
 #include "xsystem.hpp"
 
@@ -405,6 +407,8 @@ __get_cxx_version ()
         // preamble_manager["magics"].get_cast<xmagics_manager>().register_magic("file", writefile());
         // preamble_manager["magics"].get_cast<xmagics_manager>().register_magic("timeit", timeit(&m_interpreter));
         // preamble_manager["magics"].get_cast<xmagics_manager>().register_magic("python", pythonexec());
+#ifndef EMSCRIPTEN
         preamble_manager["magics"].get_cast<xmagics_manager>().register_magic("xassist", xassist());
+#endif
     }
 }