protocol/device_path: add append_device_node

Author: csssuf

src/protocol/device_path.rs

@@ -258,6 +258,7 @@ impl DevicePathFromTextProtocol {
         str_to_utf16_ptr(path)
             .map(|utf16_str| {
                 let out = unsafe { &*((self.text_to_device_path_node)(utf16_str)) };
+                // FIXME(csssuf)
                 // Ideally, at this point, we'd free utf16_str. However, free_pool(utf16_str) seems
                 // to hang here for unknown reasons. So we leak it.
                 out
@@ -268,6 +269,7 @@ impl DevicePathFromTextProtocol {
         str_to_utf16_ptr(path)
             .map(|utf16_str| {
                 let out = unsafe { &*((self.text_to_device_path)(utf16_str)) };
+                // FIXME(csssuf)
                 // Ideally, at this point, we'd free utf16_str. However, free_pool(utf16_str) seems
                 // to hang here for unknown reasons. So we leak it.
                 out
@@ -280,7 +282,7 @@ pub struct DevicePathUtilitiesProtocol {
     get_device_path_size: *const CVoid,
     duplicate_device_path: *const CVoid,
     append_device_path: unsafe extern "win64" fn(src1: *const DevicePathProtocol, src2: *const DevicePathProtocol) -> *const DevicePathProtocol,
-    append_device_node: *const CVoid,
+    append_device_node: unsafe extern "win64" fn(path: *const DevicePathProtocol, node: *const DevicePathProtocol) -> *const DevicePathProtocol,
     append_device_path_instance: *const CVoid,
     get_next_device_path_instance: *const CVoid,
     is_device_path_multi_instance: *const CVoid,
@@ -309,6 +311,17 @@ impl DevicePathUtilitiesProtocol {
         }
     }
 
+    pub fn append_device_node(&self, path: *const DevicePathProtocol, node: *const DevicePathProtocol) -> Result<*const DevicePathProtocol, Status> {
+        unsafe {
+            let out = (self.append_device_node)(path, node);
+            if out == 0 as *const DevicePathProtocol {
+                // See comment in append_device_path.
+                return Err(Status::OutOfResources);
+            }
+            Ok(out)
+        }
+    }
+
     pub fn create_device_node<T: Into<u8>, U: Into<u8>>(&self, node_type: T, node_subtype: U, node_length: u16) -> Result<*const DevicePathProtocol, Status> {
         unsafe {
             let out = (self.create_device_node)(node_type.into(), node_subtype.into(), node_length);