fix: encodeURI to correctly load specs with white space (#16416)

* fix: encodeURI to correctly load specs with white space

* fix the tests

* allow refresh page when spaes are in the path

Co-authored-by: ElevateBart <[email protected]>
Co-authored-by: Barthélémy Ledoux <[email protected]>

Author: 3 people

npm/webpack-dev-server/src/loader.ts

@@ -17,7 +17,7 @@ const makeImport = (file: Cypress.Cypress['spec'], filename: string, chunkName:
   const magicComments = chunkName ? `/* webpackChunkName: "${chunkName}" */` : ''
 
   return `"${filename}": {
-    shouldLoad: () => document.location.pathname.includes("${file.absolute}"),
+    shouldLoad: () => document.location.pathname.includes("${encodeURI(file.absolute)}"),
     load: () => import("${file.absolute}" ${magicComments}),
     chunkName: "${chunkName}",
   }`

packages/runner-ct/cypress/component/Spec With Whitespace.spec.tsx

@@ -0,0 +1,21 @@
+import React from 'react'
+import { mount } from '@cypress/react'
+import RunnerCt from '../../src/app/RunnerCt'
+import '@packages/runner/src/main.scss'
+import { makeState, fakeConfig, FakeEventManager } from './utils'
+
+describe('Spec File with Whitespace', () => {
+  it('renders RunnerCt', () => {
+    mount(
+      <RunnerCt
+        state={makeState()}
+        // @ts-ignore - this is difficult to stub. Real one breaks things.
+        eventManager={new FakeEventManager()}
+        config={fakeConfig}
+      />,
+    )
+
+    // ensures that the spec was executed
+    cy.get('h2').contains('No spec selected.')
+  })
+})

packages/runner-ct/cypress/component/utils.ts

@@ -16,3 +16,7 @@ export const getPort = (href: string) => {
 
   return port
 }
+
+export class FakeEventManager {
+  on (evt: string) {}
+}

packages/runner-ct/src/lib/state.ts

@@ -293,7 +293,7 @@ export default class State {
   }
 
   @action updateSpecByUrl (specUrl) {
-    const foundSpec = _.find(this.specs, { name: specUrl })
+    const foundSpec = _.find(this.specs, { name: decodeURI(specUrl) })
 
     if (foundSpec) {
       this.spec = foundSpec