Skip to content

Commit 307eb28

Browse files
committed
add fixme issue to stack trace mismatches inside evaled context
1 parent 0c9e81e commit 307eb28

File tree

4 files changed

+21
-0
lines changed

4 files changed

+21
-0
lines changed

packages/app/cypress/e2e/runner/reporter.command_errors.cy.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,10 @@ describe('errors ui', {
278278
})
279279
})
280280

281+
// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
282+
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
283+
// leading to a small mismatch when linking stack traces back to the user's IDE from
284+
// the command log.
281285
it('cy.intercept', () => {
282286
const verify = loadErrorSpec({
283287
filePath: 'errors/intercept.cy.ts',

packages/app/cypress/e2e/runner/reporter.errors.cy.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,10 @@ describe('errors ui', {
261261
})
262262
})
263263

264+
// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
265+
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
266+
// leading to a small mismatch when linking stack traces back to the user's IDE from
267+
// the command log.
264268
it('typescript', () => {
265269
const verify = loadErrorSpec({
266270
filePath: 'errors/typescript.cy.ts',

system-tests/projects/e2e/cypress/e2e/cy_origin_error.cy.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ describe('cy.origin errors', () => {
1818
})
1919
})
2020

21+
// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
22+
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
23+
// leading to a small mismatch when linking stack traces back to the user's IDE from
24+
// the command log.
2125
verify('command failure', this, {
2226
line: 16,
2327
message: 'Expected to find element',
@@ -36,6 +40,10 @@ describe('cy.origin errors', () => {
3640
})
3741
})
3842

43+
// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
44+
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
45+
// leading to a small mismatch when linking stack traces back to the user's IDE from
46+
// the command log.
3947
verify('failure when using dependency', this, {
4048
line: 30,
4149
message: 'Expected to find element',

system-tests/test/cy_origin_error_spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@ describe('e2e cy.origin errors', () => {
4242
expect(stdout).to.contain('AssertionError')
4343
expect(stdout).to.contain('Timed out retrying after 1ms: Expected to find element: `#doesnotexist`, but never found it.')
4444

45+
// FIXME: @see https://github.com/cypress-io/cypress/issues/29614
46+
// projects using Typescript 5 do not calculate the userInvocationStack correctly,
47+
// leading to a small mismatch when linking stack traces back to the user's IDE from
48+
// the command log.
49+
4550
// check to make sure stack trace contains the 'cy.origin' source
4651
expect(stdout).to.contain('webpack://e2e/./cypress/e2e/cy_origin_error.cy.ts:16')
4752
expect(stdout).to.contain('webpack://e2e/./cypress/e2e/cy_origin_error.cy.ts:30')

0 commit comments

Comments
 (0)