Skip to content

Commit a5bb2e0

Browse files
AkryumJessicaSachs
andauthored
fix(component testing): default config values (#15902)
Co-authored-by: Jessica Sachs <[email protected]>
1 parent 8e894a0 commit a5bb2e0

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

packages/server-ct/src/project-ct.ts

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@ import Debug from 'debug'
22
import config from '@packages/server/lib/config'
33
import plugins from '@packages/server/lib/plugins'
44
import devServer from '@packages/server/lib/plugins/dev-server'
5-
import { ProjectBase } from '@packages/server/lib/project-base'
5+
import { Cfg, ProjectBase } from '@packages/server/lib/project-base'
66
import settings from '@packages/server/lib/util/settings'
77
import specsUtil from '@packages/server/lib/util/specs'
88
import { ServerCt } from './server-ct'
99
import { SpecsStore } from './specs-store'
10-
import { options } from '@packages/server/lib/config_options'
1110

1211
export * from '@packages/server/lib/project-base'
1312

@@ -24,22 +23,12 @@ export class ProjectCt extends ProjectBase<ServerCt> {
2423
* 2. otherwise, use 500/500 by default.
2524
*/
2625
addComponentTestingUniqueDefaults (cfg: Record<string, unknown>) {
27-
const defaultViewport = options.reduce<Record<string, number>>((acc, curr) => {
28-
if (curr.name === 'viewportHeight') {
29-
return { ...acc, viewportHeight: curr.defaultValue as number }
30-
}
31-
32-
if (curr.name === 'viewportWidth') {
33-
return { ...acc, viewportWidth: curr.defaultValue as number }
34-
}
35-
36-
return acc
37-
}, {})
26+
const rawJson = cfg.rawJson as Cfg
3827

3928
return {
4029
...cfg,
41-
viewportHeight: cfg.viewportHeight !== defaultViewport.viewportHeight ? cfg.viewportHeight : 500,
42-
viewportWidth: cfg.viewportWidth !== defaultViewport.viewportWidth ? cfg.viewportWidth : 500,
30+
viewportHeight: rawJson.viewportHeight ?? 500,
31+
viewportWidth: rawJson.viewportWidth ?? 500,
4332
}
4433
}
4534

packages/server/lib/config.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,8 @@ module.exports = {
241241
mergeDefaults (config = {}, options = {}) {
242242
const resolved = {}
243243

244+
config.rawJson = _.cloneDeep(config)
245+
244246
_.extend(config, _.pick(options, 'configFile', 'morgan', 'isTextTerminal', 'socketId', 'report', 'browsers'))
245247
debug('merged config with options, got %o', config)
246248

0 commit comments

Comments
 (0)