Skip to content

fix: wrong version of webpack-dev-server displayed #22919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: wrong version of webpack-dev-server displayed #22919

merged 1 commit into from
Jul 25, 2022

Conversation

leschdom
Copy link
Contributor

User facing changelog

n/a

Additional details

it always displayed:
using webpack-dev-server v4 even when webpack-dev-server@3 is used.
This can be confusing while debugging.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@leschdom leschdom requested a review from a team as a code owner July 25, 2022 13:08
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 25, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cypress
Copy link

cypress bot commented Jul 25, 2022 •
edited
Loading


Test summary

37729 • 0 • 456 • 0 • Flakiness 9

Run details
Project cypress
Status Passed
Commit c52b30d
Started Jul 25, 2022 7:18 PM
Ended Jul 25, 2022 7:36 PM
Duration 18:11 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

commands/actions/click.cy.js 1 Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
commands/xhr.cy.js 3 Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
cypress/proxy-logging.cy.ts 1 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@leschdom leschdom force-pushed the leschdom/fix-debug-output-for-webpack-dev-server branch from 7225e47 to e61b4e1 Compare July 25, 2022 14:02
ZachJW34
ZachJW34 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Once CI is green LGTM!

@leschdom
fix: wrong version of webpack-dev-server displayed
c52b30d 
it always displayed:
`using webpack-dev-server v4` even when webpack-dev-server@3 is used.
This can be confusing while debugging.
@leschdom leschdom force-pushed the leschdom/fix-debug-output-for-webpack-dev-server branch from e61b4e1 to c52b30d Compare July 25, 2022 19:11
@marktnoonan marktnoonan mentioned this pull request Jul 25, 2022
Closed
@ZachJW34 ZachJW34 merged commit b4ae71c into cypress-io:master Jul 25, 2022
@leschdom leschdom deleted the leschdom/fix-debug-output-for-webpack-dev-server branch July 26, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

@ZachJW34 ZachJW34 ZachJW34 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leschdom @CLAassistant @emilyrohrbough @ZachJW34