Skip to content

feat: enable Angular CT support #23089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

feat: enable Angular CT support #23089

merged 1 commit into from
Aug 3, 2022

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Aug 3, 2022

User facing changelog

Enable Angular CT support

Additional details

Reverting the changes from ecad07e. Added the feat in the commit title to bump minor version in next release.

Steps to test

Code has been tested, but there are system tests you can run via yarn workspace @cypress/webpack-dev-server cypress:open --e2e and clicking on angular.cy.ts.

How has the user experience changed?

Angular CT support!

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@ZachJW34 ZachJW34 requested review from a team as code owners August 3, 2022 14:48
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 3, 2022



Test summary

37832 0 469 0Flakiness 9


Run details

Project cypress
Status Passed
Commit 53117b9
Started Aug 3, 2022 2:51 PM
Ended Aug 3, 2022 3:11 PM
Duration 19:35 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs request + response headers
3 ... > logs Method, Status, URL, and XHR
4 ... > logs response
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeeeeees

@ZachJW34 ZachJW34 merged commit 94e78eb into develop Aug 3, 2022
@ZachJW34 ZachJW34 deleted the zachw/angular-support branch August 3, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants