SimpleRangeAnalysis: Remove ±Inf typeBounds for FloatingPointType

d10c · d10c · commit 9670070274f7 · 2024-06-25T16:41:45.000+02:00
If this doesn't break any tests, then this will simplify the rewrite of all SimpleRangeAnalysis floats to BigInt.
diff --git a/cpp/ql/lib/semmle/code/cpp/rangeanalysis/RangeAnalysisUtils.qll b/cpp/ql/lib/semmle/code/cpp/rangeanalysis/RangeAnalysisUtils.qll
@@ -405,9 +405,6 @@ private predicate typeBounds(ArithmeticType t, float lb, float ub) {
         lb = 0 and ub = limit - 1
       )
   )
-  or
-  // This covers all floating point types. The range is (-Inf, +Inf).
-  t instanceof FloatingPointType and lb = -(1.0 / 0.0) and ub = 1.0 / 0.0
 }
 
 private Type stripReference(Type t) {

Original file line number	Diff line number	Diff line change
`@@ -405,9 +405,6 @@ private predicate typeBounds(ArithmeticType t, float lb, float ub) {`
`405`	`405`	`lb = 0 and ub = limit - 1`
`406`	`406`	`)`
`407`	`407`	`)`
`408`		`- or`
`409`		`- // This covers all floating point types. The range is (-Inf, +Inf).`
`410`		`- t instanceof FloatingPointType and lb = -(1.0 / 0.0) and ub = 1.0 / 0.0`
`411`	`408`	`}`
`412`	`409`
`413`	`410`	`private Type stripReference(Type t) {`