Skip to content

Commit 94e716c

Browse files
committed
Always use signbit if available
1 parent 0e980e6 commit 94e716c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

array_api_tests/pytest_helpers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -429,13 +429,13 @@ def _real_float_strict_equals(out: Array, expected: Array) -> bool:
429429

430430
# Test sign of zeroes if xp.signbit() available, otherwise ignore as it's
431431
# not that big of a deal for the perf costs.
432-
if api_version >= "2023.12" and hasattr(_xp, "signbit"):
432+
if hasattr(_xp, "signbit"):
433433
out_zero_mask = out == 0
434-
out_sign_mask = xp.signbit(out)
434+
out_sign_mask = _xp.signbit(out)
435435
out_pos_zero_mask = out_zero_mask & out_sign_mask
436436
out_neg_zero_mask = out_zero_mask & ~out_sign_mask
437437
expected_zero_mask = expected == 0
438-
expected_sign_mask = xp.signbit(expected)
438+
expected_sign_mask = _xp.signbit(expected)
439439
expected_pos_zero_mask = expected_zero_mask & expected_sign_mask
440440
expected_neg_zero_mask = expected_zero_mask & ~expected_sign_mask
441441
pos_zero_match = out_pos_zero_mask == expected_pos_zero_mask

0 commit comments

Comments
 (0)