Skip to content

Commit eabd82c

Browse files
committed
Strict xfails on CI, remove missing __dataframe__ xfails
1 parent b6f5653 commit eabd82c

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

tests/conftest.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,6 @@ def pytest_configure(config):
3939

4040

4141
ci_xfail_ids = [
42-
# vaex's and cudf's interchange dataframe doesn't have __dataframe__()
43-
# See https://github.com/data-apis/dataframe-api/issues/80
44-
"test_dataframe_object.py::test_dunder_dataframe[vaex]",
45-
"test_signatures.py::test_dataframe_method[vaex-__dataframe__]",
46-
"test_dataframe_object.py::test_dunder_dataframe[cudf]",
47-
"test_signatures.py::test_dataframe_method[cudf-__dataframe__]",
4842
# https://github.com/vaexio/vaex/pull/2150
4943
"tests/test_signatures.py::test_column_method[vaex-size]",
5044
# https://github.com/rapidsai/cudf/issues/11320
@@ -91,7 +85,7 @@ def pytest_collection_modifyitems(config, items):
9185
if config.getoption("--ci"):
9286
for item in items:
9387
if any(id_ in item.nodeid for id_ in ci_xfail_ids):
94-
item.add_marker(pytest.mark.xfail())
88+
item.add_marker(pytest.mark.xfail(strict=True))
9589
elif any(id_ in item.nodeid for id_ in ci_skip_ids):
9690
item.add_marker(pytest.mark.skip("flaky"))
9791
elif r_cudf_roundtrip.search(item.nodeid):

0 commit comments

Comments
 (0)