Skip to content

Commit 45bdf76

Browse files
luci-bisection@appspot.gserviceaccount.comcopybara-github
authored andcommitted
Revert "build: Use -fno-strict-overflow instead of -fwrapv"
This reverts commit dc86334c39e93197a89a9201475db12f4b42c9c9. Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8724486005851749873 Sample failed build: https://ci.chromium.org/b/8724486005851749873 If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6207309&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8724486005851749873&type=BUG Original change's description: > build: Use -fno-strict-overflow instead of -fwrapv > > In gcc, -fwrapv only controls signed integer overflow, and > -fwrapv-pointer only controls pointer overflow. > > In our current clang, -fwrapv controls both, but in a new > clang [1], clang is moving to match gcc. > > -fno-strict-overflow controls both signed integer and > pointer overflow. Switch to that to get the same behavior for > new clang (and current clang) that we currently have, and to > also give gcc that behavior. > > No intentional behavior change in clang builds. With current > clang, -fwrapv and -fno-strict-overflow should mean the same > thing. > > Once we updated to new clang, we can consider using just > -fwrapv-pointer. > > 1: llvm/llvm-project#122486 > > Bug: 336282133,384391188,389103111 > Change-Id: I6ace8efb4e547ec84ce069c097dce464b15d63ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6207309 > Auto-Submit: Nico Weber <[email protected]> > Reviewed-by: Hans Wennborg <[email protected]> > Commit-Queue: Nico Weber <[email protected]> > Commit-Queue: Hans Wennborg <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1412288} > Bug: 336282133,384391188,389103111 Change-Id: I6b6d87fd75059dd782f8a3a16c30a6668e354bb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6208248 Bot-Commit: [email protected] <[email protected]> Owners-Override: [email protected] <[email protected]> Commit-Queue: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#1412319} NOKEYCHECK=True GitOrigin-RevId: 86a302d2ce8c8ff36047f5700d7737fddb4e9c00
1 parent 51336f3 commit 45bdf76

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

config/compiler/BUILD.gn

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,9 +333,9 @@ config("compiler") {
333333
# When UBSan is enabled, we want to continue flagging overflows as a bug.
334334
if (!is_ubsan && (!is_win || is_clang)) {
335335
if (is_win) {
336-
cflags += [ "/clang:-fno-strict-overflow" ]
336+
cflags += [ "/clang:-fwrapv" ]
337337
} else {
338-
cflags += [ "-fno-strict-overflow" ]
338+
cflags += [ "-fwrapv" ]
339339
}
340340
}
341341

0 commit comments

Comments
 (0)