Skip to content

Commit 0660903

Browse files
devversionAndrewKushnir
authored andcommitted
ci: remove material-unit-tests failure blocklist (angular#32138)
Initially when the `material-unit-tests` job got wired up, Ivy was not really backwards-compatible and a few bugs caused test failures when running the Angular Material test suites w/ Ivy. These bugs got fixed progressively and eventually the test blocklist became empty. At this point we don't want to regress in the future and the blocklist should never have new items. Additionally since we switched the unit-tests job to run against Angular Material `master` with Bazel, the blocklist is no longer respected. Therefore we can safely remove the blocklist. PR Close angular#32138
1 parent 984d23f commit 0660903

File tree

4 files changed

+0
-56
lines changed

4 files changed

+0
-56
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -911,14 +911,6 @@ testing/** @angular/fw-test
911911

912912

913913

914-
# ================================================
915-
# Material CI
916-
# ================================================
917-
918-
/tools/material-ci/** @angular/fw-core @angular/framework-global-approvers
919-
920-
921-
922914
# ================================================
923915
# Public API
924916
# ================================================

scripts/ci/run_angular_material_unit_tests.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ cd ${MATERIAL_REPO_TMP_DIR}
2121
# Note that it's not necessary to perform a yarn install, as Bazel performs its own yarn install.
2222
node ${angular_dir}/scripts/ci/update-deps-to-dist-packages.js ${MATERIAL_REPO_TMP_DIR}/package.json ${angular_dir}/dist/packages-dist-ivy-aot/
2323

24-
# Append the test blocklist into angular/material2's karma-test-shim.js.
25-
# This filters out known-failing tests because the goal is to prevent regressions.
26-
cat ${angular_dir}/tools/material-ci/angular_material_test_blocklist.js >> ./test/karma-test-shim.js
27-
2824
# Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors.
2925
./scripts/circleci/setup_bazel_binary.sh
3026

tools/material-ci/angular_material_test_blocklist.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

tools/material-ci/instructions.md

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)