Skip to content

Commit 90804df

Browse files
committed
unused: detect struct conversions involving generics
(cherry picked from commit d694aad)
1 parent 0ccdb5c commit 90804df

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

unused/testdata/src/typeparams/typeparams.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,3 +89,17 @@ func fn11[T ~struct{ Field int }]() { // unused
8989
// don't crash because of the composite literal
9090
_ = T{Field: 42}
9191
}
92+
93+
type convertGeneric1 struct { // used
94+
field int // used
95+
}
96+
97+
type convertGeneric2 struct { // used
98+
field int // used
99+
}
100+
101+
var _ = convertGeneric1{}.field // mark field as used
102+
103+
func Fn12[T1 convertGeneric1, T2 convertGeneric2](a T1) { // used
104+
_ = T2(a) // conversion marks T2.field as used
105+
}

unused/unused.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1662,8 +1662,8 @@ func (g *graph) instructions(fn *ir.Function) {
16621662
case *ir.ChangeType:
16631663
// conversion type handled generically
16641664

1665-
s1, ok1 := typeutil.Dereference(instr.Type()).Underlying().(*types.Struct)
1666-
s2, ok2 := typeutil.Dereference(instr.X.Type()).Underlying().(*types.Struct)
1665+
s1, ok1 := typeutil.CoreType(typeutil.Dereference(instr.Type())).(*types.Struct)
1666+
s2, ok2 := typeutil.CoreType(typeutil.Dereference(instr.X.Type())).(*types.Struct)
16671667
if ok1 && ok2 {
16681668
// Converting between two structs. The fields are
16691669
// relevant for the conversion, but only if the

0 commit comments

Comments
 (0)