Skip to content

Commit 9f8f8c0

Browse files
Backport TLS test minimum OS (#33714)
Backport part of fe6a3fc to address the flaky test in release/5.0
1 parent 9c12972 commit 9f8f8c0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/Servers/Kestrel/test/InMemory.FunctionalTests/EventSourceTests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,8 @@ public async Task Http2_EmitsStartAndStopEventsWithActivityIds()
268268
Assert.Equal(eventIndex, events.Count);
269269
}
270270

271-
[Fact]
271+
[ConditionalFact]
272+
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "SslStream.AuthenticateAsServerAsync() doesn't throw on Win 7 when the client tries SSL 2.0.")]
272273
public async Task TlsHandshakeFailure_EmitsStartAndStopEventsWithActivityIds()
273274
{
274275
int port;
@@ -298,7 +299,7 @@ public async Task TlsHandshakeFailure_EmitsStartAndStopEventsWithActivityIds()
298299
{
299300
TargetHost = "localhost",
300301

301-
// Only enabling SslProtocols.Ssl2 should cause a handshake failure on all platforms.
302+
// Only enabling SslProtocols.Ssl2 should cause a handshake failure on most platforms.
302303
#pragma warning disable CS0618 // Type or member is obsolete
303304
EnabledSslProtocols = SslProtocols.Ssl2,
304305
#pragma warning restore CS0618 // Type or member is obsolete

0 commit comments

Comments
 (0)