Skip to content

Commit 1974dc1

Browse files
authored
Only increase reconnect backoff if all addrinfos have been tried (#1423)
1 parent 5446d18 commit 1974dc1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

kafka/conn.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ def __init__(self, host, port, afi, **configs):
264264
self._ssl_context = self.config['ssl_context']
265265
self._sasl_auth_future = None
266266
self.last_attempt = 0
267-
self._gai = None
267+
self._gai = []
268268
self._sensors = None
269269
if self.config['metrics']:
270270
self._sensors = BrokerConnectionMetrics(self.config['metrics'],
@@ -638,6 +638,9 @@ def _reset_reconnect_backoff(self):
638638
self._reconnect_backoff = self.config['reconnect_backoff_ms'] / 1000.0
639639

640640
def _update_reconnect_backoff(self):
641+
# Do not mark as failure if there are more dns entries available to try
642+
if len(self._gai) > 0:
643+
return
641644
if self.config['reconnect_backoff_max_ms'] > self.config['reconnect_backoff_ms']:
642645
self._failures += 1
643646
self._reconnect_backoff = self.config['reconnect_backoff_ms'] * 2 ** (self._failures - 1)

0 commit comments

Comments
 (0)