Skip to content

Commit 5e4def7

Browse files
authored
Check for socket and unresolved futures before creating selector in conn.check_version (#2477)
1 parent 21031e6 commit 5e4def7

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

kafka/conn.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,13 +1255,14 @@ def reset_override_configs():
12551255
# request was unrecognized
12561256
mr = self.send(MetadataRequest[0](topics))
12571257

1258-
selector = self.config['selector']()
1259-
selector.register(self._sock, selectors.EVENT_READ)
1260-
while not (f.is_done and mr.is_done):
1261-
selector.select(1)
1262-
for response, future in self.recv():
1263-
future.success(response)
1264-
selector.close()
1258+
if not (f.is_done and mr.is_done) and self._sock is not None:
1259+
selector = self.config['selector']()
1260+
selector.register(self._sock, selectors.EVENT_READ)
1261+
while not (f.is_done and mr.is_done):
1262+
selector.select(1)
1263+
for response, future in self.recv():
1264+
future.success(response)
1265+
selector.close()
12651266

12661267
if f.succeeded():
12671268
if isinstance(request, ApiVersionRequest[0]):

0 commit comments

Comments
 (0)