Skip to content

Commit 68d8aad

Browse files
author
Tyler Lubeck
committed
Add support for DescribeConfigs API v2
1 parent 9c55a30 commit 68d8aad

File tree

2 files changed

+37
-3
lines changed

2 files changed

+37
-3
lines changed

kafka/admin/client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,7 @@ def describe_configs(self, config_resources, include_synonyms=False):
802802
DescribeConfigsRequest[version](resources=topic_resources)
803803
))
804804

805-
elif version == 1:
805+
elif version <= 2:
806806
if len(broker_resources) > 0:
807807
for broker_resource in broker_resources:
808808
try:

kafka/protocol/admin.py

+36-2
Original file line numberDiff line numberDiff line change
@@ -708,6 +708,28 @@ class DescribeConfigsResponse_v1(Response):
708708
('config_source', Int8)))))))
709709
)
710710

711+
class DescribeConfigsResponse_v2(Response):
712+
API_KEY = 32
713+
API_VERSION = 2
714+
SCHEMA = Schema(
715+
('throttle_time_ms', Int32),
716+
('resources', Array(
717+
('error_code', Int16),
718+
('error_message', String('utf-8')),
719+
('resource_type', Int8),
720+
('resource_name', String('utf-8')),
721+
('config_entries', Array(
722+
('config_names', String('utf-8')),
723+
('config_value', String('utf-8')),
724+
('read_only', Boolean),
725+
('config_source', Int8),
726+
('is_sensitive', Boolean),
727+
('config_synonyms', Array(
728+
('config_name', String('utf-8')),
729+
('config_value', String('utf-8')),
730+
('config_source', Int8)))))))
731+
)
732+
711733
class DescribeConfigsRequest_v0(Request):
712734
API_KEY = 32
713735
API_VERSION = 0
@@ -731,8 +753,20 @@ class DescribeConfigsRequest_v1(Request):
731753
('include_synonyms', Boolean)
732754
)
733755

734-
DescribeConfigsRequest = [DescribeConfigsRequest_v0, DescribeConfigsRequest_v1]
735-
DescribeConfigsResponse = [DescribeConfigsResponse_v0, DescribeConfigsResponse_v1]
756+
class DescribeConfigsRequest_v2(Request):
757+
API_KEY = 32
758+
API_VERSION = 2
759+
RESPONSE_TYPE = DescribeConfigsResponse_v2
760+
SCHEMA = DescribeConfigsRequest_v2.SCHEMA
761+
762+
DescribeConfigsRequest = [
763+
DescribeConfigsRequest_v0, DescribeConfigsRequest_v1,
764+
DescribeConfigsRequest_v2,
765+
]
766+
DescribeConfigsResponse = [
767+
DescribeConfigsResponse_v0, DescribeConfigsResponse_v1,
768+
DescribeConfigsResponse_v2,
769+
]
736770

737771
class SaslAuthenticateResponse_v0(Response):
738772
API_KEY = 36

0 commit comments

Comments
 (0)