Skip to content

Commit a357c11

Browse files
committed
Fix silently ignoring file path in pvsystem.retrieve_sam when name is provided (pvlib#2020)
* My approach to the issue * Deprecate previous parameters * No reason to over-engineer, right? * Update v0.10.5.rst * Update pvsystem.py * Improve error handling * Add ppl involved * kevin's suggestions
1 parent ec717a9 commit a357c11

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

docs/sphinx/source/whatsnew/v0.10.5.rst

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,13 @@ Bug fixes
3131
* Fixed :py:func:`pvlib.pvsystem.retrieve_sam` silently ignoring the ``path`` parameter
3232
when ``name`` was provided. Now an exception is raised requesting to only provide one
3333
of the two parameters. (:issue:`2018`, :pull:`2020`)
34+
* Fixed :py:func:`pvlib.pvsystem.retrieve_sam` silently ignoring the `path` parameter
35+
when `name` was provided. Now an exception is raised requesting to only provide one
36+
of the two parameters. (:issue:`2018`, :pull:`2020`)
37+
38+
39+
Testing
40+
~~~~~~~
3441

3542

3643
Documentation
@@ -57,3 +64,5 @@ Contributors
5764
* Scott Meredith (:ghuser:`smmeredith`)
5865
* Alexander Morgan (:ghuser:`alexandermorgan`)
5966
* Kevin Anderson (:ghuser:`kandersolar`)
67+
* :ghuser:`apct69`
68+
* Mark Mikofski (:ghuser:`mikofski`)

0 commit comments

Comments
 (0)