Skip to content

Commit b9c5fa4

Browse files
authored
Rollup merge of rust-lang#35353 - poveda-ruiz:master, r=jonathandturner
Updated E0081 to new format Part of rust-lang#35233. r? @jonathandturner
2 parents 8e1b96a + 00179a7 commit b9c5fa4

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

src/librustc_typeck/check/mod.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1251,8 +1251,9 @@ pub fn check_enum_variants<'a,'tcx>(ccx: &CrateCtxt<'a,'tcx>,
12511251
let mut err = struct_span_err!(ccx.tcx.sess, v.span, E0081,
12521252
"discriminant value `{}` already exists", disr_vals[i]);
12531253
let variant_i_node_id = ccx.tcx.map.as_local_node_id(variants[i].did).unwrap();
1254-
span_note!(&mut err, ccx.tcx.map.span(variant_i_node_id),
1255-
"conflicting discriminant here");
1254+
err.span_label(ccx.tcx.map.span(variant_i_node_id),
1255+
&format!("first use of `{}`", disr_vals[i]));
1256+
err.span_label(v.span , &format!("enum already has `{}`", disr_vals[i]));
12561257
err.emit();
12571258
}
12581259
disr_vals.push(current_disr_val);

src/test/compile-fail/issue-15524.rs

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,18 @@ const N: isize = 1;
1212

1313
enum Foo {
1414
A = 1,
15-
B = 1, //~ ERROR discriminant value `1isize` already exists
16-
//~^^ NOTE conflicting
15+
//~^ NOTE first use
16+
//~| NOTE first use
17+
//~| NOTE first use
18+
B = 1, //~ ERROR discriminant value
19+
//~^ NOTE enum already
1720
C = 0,
18-
D, //~ ERROR discriminant value `1isize` already exists
19-
//~^^^^^ NOTE conflicting
20-
E = N, //~ ERROR discriminant value `1isize` already exists
21-
//~^^^^^^^ NOTE conflicting
21+
D, //~ ERROR discriminant value
22+
//~^ NOTE enum already
23+
24+
E = N, //~ ERROR discriminant value
25+
//~^ NOTE enum already
26+
2227
}
2328

2429
fn main() {}

0 commit comments

Comments
 (0)