Skip to content

Commit 432d6fa

Browse files
GuillaumeMilanjosevalim
authored andcommitted
Fix crashing on autocompleting structs with runtime values (#14150)
1 parent 24714c6 commit 432d6fa

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

lib/iex/lib/iex/autocomplete.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ defmodule IEx.Autocomplete do
363363
end)
364364

365365
entries =
366-
for {key, _value} <- pairs,
366+
for key when key != :__struct__ <- Map.keys(pairs),
367367
name = Atom.to_string(key),
368368
if(hint == "",
369369
do: not String.starts_with?(name, "_"),

lib/iex/test/iex/autocomplete_test.exs

+13
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,19 @@ defmodule IEx.AutocompleteTest do
430430
assert {:yes, ~c"ry: ", []} = expand(~c"%URI{var | path: \"foo\", que")
431431
assert {:no, [], []} = expand(~c"%URI{var | path: \"foo\", unkno")
432432
assert {:no, [], []} = expand(~c"%Unknown{var | path: \"foo\", unkno")
433+
434+
eval("var = %URI{}")
435+
436+
assert {:yes, ~c"", entries} = expand(~c"%{var | ")
437+
assert ~c"path:" in entries
438+
assert ~c"query:" in entries
439+
440+
assert {:yes, ~c"", entries} = expand(~c"%{var | path: \"foo\",")
441+
assert ~c"path:" not in entries
442+
assert ~c"query:" in entries
443+
444+
assert {:yes, ~c"ry: ", []} = expand(~c"%{var | path: \"foo\", que")
445+
assert {:no, [], []} = expand(~c"%URI{var | path: \"foo\", unkno")
433446
end
434447

435448
test "completion for map keys in update syntax" do

0 commit comments

Comments
 (0)