Skip to content

Commit ef1450d

Browse files
Fix crashing on autocompleting structs with runtime values (#14150)
1 parent 9256143 commit ef1450d

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

lib/iex/lib/iex/autocomplete.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ defmodule IEx.Autocomplete do
362362
end)
363363

364364
entries =
365-
for {key, _value} <- pairs,
365+
for key when key != :__struct__ <- Map.keys(pairs),
366366
name = Atom.to_string(key),
367367
if(hint == "",
368368
do: not String.starts_with?(name, "_"),

lib/iex/test/iex/autocomplete_test.exs

+13
Original file line numberDiff line numberDiff line change
@@ -440,6 +440,19 @@ defmodule IEx.AutocompleteTest do
440440
assert {:yes, ~c"ry: ", []} = expand(~c"%URI{var | path: \"foo\", que")
441441
assert {:no, [], []} = expand(~c"%URI{var | path: \"foo\", unkno")
442442
assert {:no, [], []} = expand(~c"%Unknown{var | path: \"foo\", unkno")
443+
444+
eval("var = %URI{}")
445+
446+
assert {:yes, ~c"", entries} = expand(~c"%{var | ")
447+
assert ~c"path:" in entries
448+
assert ~c"query:" in entries
449+
450+
assert {:yes, ~c"", entries} = expand(~c"%{var | path: \"foo\",")
451+
assert ~c"path:" not in entries
452+
assert ~c"query:" in entries
453+
454+
assert {:yes, ~c"ry: ", []} = expand(~c"%{var | path: \"foo\", que")
455+
assert {:no, [], []} = expand(~c"%URI{var | path: \"foo\", unkno")
443456
end
444457

445458
test "completion for map keys in update syntax" do

0 commit comments

Comments
 (0)